Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift to SpeziLLM #17

Merged
merged 13 commits into from
Feb 26, 2024
Merged

Lift to SpeziLLM #17

merged 13 commits into from
Feb 26, 2024

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Jan 22, 2024

Lift to SpeziLLM

♻️ Current situation & Problem

Dependent on old version of SpeziLLM

⚙️ Release Notes

  • Update to SpeziLLM version 0.7.0

📚 Documentation

Proper docs included

✅ Testing

All tests passing

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar self-assigned this Jan 22, 2024
@philippzagar philippzagar added the enhancement New feature or request label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: Patch coverage is 1.20482% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 39.95%. Comparing base (07c2e56) to head (3bdd736).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   42.87%   39.95%   -2.92%     
==========================================
  Files          26       20       -6     
  Lines        1297     1154     -143     
==========================================
- Hits          556      461      -95     
+ Misses        741      693      -48     
Files Coverage Δ
...FHIRMockPatients/FoundationBundle+LoadBundle.swift 81.25% <100.00%> (ø)
...eziFHIRMockPatients/FHIRStore+TestingSupport.swift 0.00% <0.00%> (ø)
...peziFHIRMockPatients/FHIRBundle+MockPatients.swift 44.07% <0.00%> (-55.93%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c2e56...3bdd736. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the updates moving to Spezi FHIR. I only had one comment about the change of coaching. Once this is resolved and the upstream PR is merged it would be great to see this merged as well 👍

Package.swift Outdated Show resolved Hide resolved
@philippzagar philippzagar marked this pull request as ready for review February 26, 2024 06:55
@philippzagar
Copy link
Member Author

@PSchmiedmayer PR is ready to merge, as the test coverage decreased a bit, please force merge the PR! (we can also do that within our meeting tomorrow!)

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements @philippzagar; I only had a few smaller comments, we can discuss them in our meeting tomorrow morning 👍

@philippzagar
Copy link
Member Author

@philippzagar I'll finish the localizations after our meeting!

@philippzagar
Copy link
Member Author

@PSchmiedmayer Please force merge the PR, as discussed in our meeting :)

@PSchmiedmayer PSchmiedmayer merged commit 9a171a2 into main Feb 26, 2024
7 of 8 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feat/lift-to-spezi-llm branch February 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants