-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SpeziPersonalInfo target #20
Conversation
@PSchmiedmayer are there any other changes we want to bring to SpeziViews? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements, looks great! 👍
Nice work @Supereg! |
Oh, sorry, missed the message here. The main thing would be the re-organization that we alluded to in our meeting yesterday but that might be a separate PR but maybe something we address before we tag a new breaking release? |
… catalogs. Removed HTMLView
@PSchmiedmayer as discussed I extended the scope of the PR to start with splitting SpeziViews into multiple targets. As this substantially changed the scope of the PR, I just re-requested a review from you. Looking through the updated PR description should give you a good overview of the updated scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for the work here!
Tests/UITests/UITests.xcodeproj/xcshareddata/xcschemes/TestApp.xcscheme
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
- Coverage 75.47% 73.33% -2.14%
==========================================
Files 23 21 -2
Lines 856 686 -170
==========================================
- Hits 646 503 -143
+ Misses 210 183 -27
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
# Add PersonalInfo and Validation to SPI documentation targets ## ♻️ Current situation & Problem #20 and #21 introduced additional documentation targets. This PR adds them to the spi.yml such that the Swift Package Index properly builds them. ## ⚙️ Release Notes * Configured new documentation targets to be exported to SPI. ## 📚 Documentation -- ## ✅ Testing -- ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Introduce SpeziPersonalInfo target
♻️ Current situation & Problem
Previously,
SpeziViews
was treated like a catch all for any UI-component-based API interfaces. This PR introducesSpeziPersonInfo
that paves the way for a more granular grouping of UI components. In this PR we move out any UI components that deal with personal information. There might be future additions coming from a SpeziAccount refactoring.This brings some breaking changes, where we removed the
NameFields
view and instead replaced it with new optimized viewsNameTextField
andNameFieldRow
. These address specific parts of aPersonNameComponents
and remove a lot of the complexity like focus state handling. As you now can directly access the individual TextFields, this can be more cleanly handled by the users themselves.Further this PR removes the unused
HTMLView
(andDocumentView
).MarkdownView
remains.This PR updates the project to target a deployment target of iOS 17 and migrates to use the new String Catalogs. We made sure to use the explicit
init(verbatim:)
initializer forText
views where necessary. We exposed similar functionality with ourLazyText
undLabel
views. External parameters were changed and induce a breaking change.⚙️ Release Notes
SpeziPersonalInfo
target is the entry point for all View components that deal with personal information.NameFields
view was removed and replaced with row-based viewsNameTextField
andNameFieldRow
.HTMLView
andDocumentView
were removed.LazyText
andLabel
views.📚 Documentation
The PR adds documentation catalogs to both targets which were previously missing. Through these documentation catalogs we create a structure that allows to more easily explore SpeziViews and SpeziPersonalInfo packages. Certain documentation was optimized to more clearly communicate the technical details.
✅ Testing
Testing was update to separate functionality of the two new targets to provide a clear separation between both.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: