Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dependency method #105

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Conversation

yurii-lunha-stansassets
Copy link
Contributor

Purpose of this PR

Extending the class to remove dependency from manifest

Testing status

Manual testing status

Teste in https://github.com/StansAssets/com.stansassets.package-manager project.

Comments to reviewers

I'm using Manifest class to add/remove dependencies from manifest file

Copy link
Contributor

@alexey-yaremenko alexey-yaremenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! I raised a few crucial points in the comments down below.

Editor/Manifest/Manifest.cs Outdated Show resolved Hide resolved
Editor/Manifest/Manifest.cs Show resolved Hide resolved
Copy link
Contributor

@alexey-yaremenko alexey-yaremenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Please, consider and apply my suggested changes.

Editor/Manifest/Manifest.cs Outdated Show resolved Hide resolved
Editor/Manifest/Manifest.cs Outdated Show resolved Hide resolved
Co-authored-by: Oleksii Yaremenko <alex.g.yaremenko@gmail.com>
Co-authored-by: Oleksii Yaremenko <alex.g.yaremenko@gmail.com>
Copy link
Contributor

@alexey-yaremenko alexey-yaremenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply, lovely.

@kodiakhq kodiakhq bot merged commit ed92621 into master Mar 20, 2023
@kodiakhq kodiakhq bot deleted the feat/manifest-remove-dependency branch March 20, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants