-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove dependency method #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! I raised a few crucial points in the comments down below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Please, consider and apply my suggested changes.
Co-authored-by: Oleksii Yaremenko <alex.g.yaremenko@gmail.com>
Co-authored-by: Oleksii Yaremenko <alex.g.yaremenko@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply, lovely.
Purpose of this PR
Extending the class to remove dependency from manifest
Testing status
Manual testing status
Teste in https://github.com/StansAssets/com.stansassets.package-manager project.
Comments to reviewers
I'm using Manifest class to add/remove dependencies from manifest file