Add upload date in List View #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -49,6 +49,11 @@ | |||
| white-space: nowrap; | |||
| text-overflow: ellipsis; | |||
| } | |||
| .upload-date { | |||
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
JtheDroid
commented
Apr 17, 2019
| @@ -90,7 +90,7 @@ class SongList extends Component { | |||
| ] | |||
| return ( | |||
| <ContextMenuTrigger id={ song.hash || song.hashMd5 }> | |||
| <SongListItem key={ makeRenderKey(songTags) } title={ song.songName } ratings={ song.ratings } artist={ song.authorName } uploader={ song.uploader } difficulties={ song.difficulties || song.difficultyLevels } imageSource={ song.coverUrl } songKey={ song.key } hash={ song.hash || song.hashMd5 } file={ song.file } downloads={ song.downloadCount } upvotes={ song.upVotes } downvotes={ song.downVotes } plays={ song.playedCount } /> | |||
| <SongListItem key={ makeRenderKey(songTags) } title={ song.songName } ratings={ song.ratings } artist={ song.authorName } uploader={ song.uploader } difficulties={ song.difficulties || song.difficultyLevels } imageSource={ song.coverUrl } songKey={ song.key } hash={ song.hash || song.hashMd5 } file={ song.file } downloads={ song.downloadCount } upvotes={ song.upVotes } downvotes={ song.downVotes } plays={ song.playedCount } uploadDate={ !!song.createdAt && !!song.createdAt.date && !!song.createdAt.timezone ? new Date(Date.parse(song.createdAt.date + " " + song.createdAt.timezone)).toLocaleString() : '' } /> | |||
There was a problem hiding this comment.
Probably not the best place to parse the date, but I didn't really know where else to do it
|
@JtheDroid Do you think it would look better as:
or
|
|
@StarGazer1258 I personally think
looks better/makes more sense But maybe the date could go somewhere else, that position was just my first idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the upload date in the List View as requested in Issue #13
Not displayed in Compact or Grid Views
Before:
After:
Date is formatted using the computer's default locale
Example: German locale:
Feel free to change anything