[BugFix] Update total stat of PrimaryKey tablet after full clone #10786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run starrocks_admit_test |
chaoyli
approved these changes
Sep 3, 2022
|
run starrocks_admit_test |
chaoyli
approved these changes
Sep 3, 2022
trueeyu
approved these changes
Sep 3, 2022
|
@mergify backport branch-2.3 |
|
@mergify backport branch-2.4 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2022
If a PrimaryKey tablet do full clone, we will clear the rowsets before and copy new rowsets, but we don't update the _cur_total_rows and _cur_total_dels after clone. So the following check in compaction maybe failed. (cherry picked from commit 9f53b8f)
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 3, 2022
If a PrimaryKey tablet do full clone, we will clear the rowsets before and copy new rowsets, but we don't update the _cur_total_rows and _cur_total_dels after clone. So the following check in compaction maybe failed. (cherry picked from commit 9f53b8f)
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 3, 2022
If a PrimaryKey tablet do full clone, we will clear the rowsets before and copy new rowsets, but we don't update the _cur_total_rows and _cur_total_dels after clone. So the following check in compaction maybe failed. (cherry picked from commit 9f53b8f)
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 3, 2022
If a PrimaryKey tablet do full clone, we will clear the rowsets before and copy new rowsets, but we don't update the _cur_total_rows and _cur_total_dels after clone. So the following check in compaction maybe failed. (cherry picked from commit 9f53b8f)
|
It seams that there is another bug of primary key model when reusing some struct without reset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #
Problem Summary(Required) ：
If a PrimaryKey tablet do full clone, we will clear the rowsets before and copy new rowsets, but we don't update the
_cur_total_rowsand_cur_total_delsafter clone. So the following check in compaction maybe failed.Checklist: