[BugFix] fix uncorrect logical properties when apply LowCardinality optimize #11793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seaven
previously approved these changes
Sep 28, 2022
Seaven
previously approved these changes
Sep 29, 2022
|
run starrocks_admit_test |
|
run starrocks_admit_test |
|
run starrocks_fe_unittest |
stdpain
force-pushed
the
decode_node_expr
branch
from
ee9abd8
to
fae0561
Compare
|
run starrocks_admit_test |
Seaven
previously approved these changes
Sep 30, 2022
Youngwb
previously approved these changes
Sep 30, 2022
|
run starrocks_admit_test |
stdpain
force-pushed
the
decode_node_expr
branch
from
fae0561
to
96b76f2
Compare
|
run starrocks_admit_test |
1 similar comment
|
run starrocks_admit_test |
|
run starrocks_admit_test |
|
run starrocks_admit_test |
|
run starrocks_admit_test |
|
Kudos, SonarCloud Quality Gate passed! |
[FE PR Coverage Check]😍 pass : 65 / 66 (98.48%) file detail
|
kangkaisen
approved these changes
Oct 3, 2022
imay
approved these changes
Oct 3, 2022
|
https://github.com/Mergifyio backport branch-2.4 |
✅ Backports have been created
|
|
https://github.com/Mergifyio backport branch-2.3 branch-2.2 |
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
…ptimize (#11793) we should rewrite logical property after OptExpression rewrite (cherry picked from commit 2ac5807) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/tree/AddDecodeNodeForDictStringRule.java # fe/fe-core/src/main/java/com/starrocks/sql/plan/ScalarOperatorToExpr.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/LowCardinalityTest.java
✅ Backports have been created
|
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Oct 24, 2022
…ptimize (StarRocks#11793) we should rewrite logical property after OptExpression rewrite
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 25, 2022
…ptimize (#11793) we should rewrite logical property after OptExpression rewrite
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #9104
Problem Summary(Required) ：
we should rewrite logical property after OptExpression rewrite
Checklist: