Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Pruning of bucketed columns first follows TABLET HINT #13142

Merged
merged 1 commit into from Nov 9, 2022

Conversation

HangyuanLiu
Copy link
Contributor

@HangyuanLiu HangyuanLiu commented Nov 9, 2022

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #13141

Problem Summary(Required) :

There are currently two problems.

  1. The optimizer will cut out the tablet specified in the tablet hint, which does not conform to the logic of hint. If the user specifies hint, no automatic optimization should be performed on the position corresponding to hint.
  2. If the number of tablets in the table is very large, the logic of bucketing tablet clipping will make an intersection "retainAll" between the full tablet and the hint tablet. This is very time-consuming and may cause the query plan to take too long.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

@HangyuanLiu HangyuanLiu changed the title Pruning of bucketed columns first follows TABLET HINT [BugFix] Pruning of bucketed columns first follows TABLET HINT Nov 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 6 / 7 (85.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/DistributionPruneRule.java 6 7 85.71% [50]

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Nov 9, 2022
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Ready to merge be-build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When there are too many tablets, using the tablet hint causes the plan to take too long
5 participants