[BugFix] Acquire rowsets at querying #13830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify backport branch-2.3 branch-2.4 branch-2.5 |
✅ Backports have been created
|
branch-2.2 need to be cherry-picked manually. |
kangkaisen
approved these changes
Nov 22, 2022
|
run starrocks_clang-tidy |
|
run starrocks_clang-tidy |
|
clang-tidy review says "All clean, LGTM! 👍" |
mofeiatwork
approved these changes
Nov 22, 2022
|
run starrocks_admit_test |
|
@Mergifyio backport branch-2.5 |
|
@Mergifyio backport branch-2.4 |
|
@Mergifyio backport branch-2.3 |
|
@Mergifyio backport branch-2.2 |
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
(cherry picked from commit c0a1b94) # Conflicts: # be/src/exec/pipeline/scan/olap_scan_context.cpp
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
(cherry picked from commit c0a1b94)
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
(cherry picked from commit c0a1b94)
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
(cherry picked from commit c0a1b94) # Conflicts: # be/src/exec/pipeline/scan/olap_scan_context.cpp # be/src/exec/pipeline/scan/olap_scan_context.h # be/src/exec/pipeline/scan/olap_scan_prepare_operator.cpp # be/src/exec/pipeline/scan/olap_scan_prepare_operator.h
|
Kudos, SonarCloud Quality Gate passed!
|
|
clang-tidy review says "All clean, LGTM! 👍" |
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 23, 2022
(cherry picked from commit c0a1b94)
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 23, 2022
(cherry picked from commit c0a1b94)
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Nov 24, 2022
This was referenced Nov 24, 2022
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Nov 24, 2022
ZiheLiu
added a commit
that referenced
this pull request
Nov 25, 2022
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 25, 2022
choury
pushed a commit
that referenced
this pull request
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
This issue #3689 occurs again.
And maybe cause BE to be crashed.
Problem Summary(Required) ：
#5056 changes the behaviour of stale rowsets.
shared_ptr<RowSet>.use_count()is one.shared_ptr.use_count()is greater than one but_refs_by_readeris zero.Therefore, we need acquire rowsets after capturing them at querying.
Because we need call
release_rowsetsafterOlapScanPrepareOperatorandOlapScanOperatorare both destructed, we move the logic ofcapture_tablet_rowsetsfromOlapScanPrepareOperatortoOlapScanContext.Checklist: