[Enhancement] optimize performance of percentile_cont function #14609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdpain
previously approved these changes
Dec 5, 2022
mofeiatwork
force-pushed
the
murphy_opt_percentile_cont
branch
from
8d43a3c
to
ee3fc3b
Compare
silverbullet233
approved these changes
Dec 5, 2022
|
clang-tidy review says "All clean, LGTM! 👍" |
|
SonarCloud Quality Gate failed.
|
|
run starrocks_admit_test |
stdpain
approved these changes
Dec 6, 2022
|
run starrocks_admit_test |
satanson
approved these changes
Dec 6, 2022
|
run starrocks_admit_test |
|
@Mergifyio backport branch-2.5 |
|
@Mergifyio backport branch-2.4 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
(cherry picked from commit 4e3418c) # Conflicts: # be/src/exprs/agg/percentile_cont.h
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
(cherry picked from commit 4e3418c) # Conflicts: # be/src/exprs/agg/percentile_cont.h
✅ Backports have been created
|
mofeiatwork
pushed a commit
that referenced
this pull request
Dec 8, 2022
mofeiatwork
pushed a commit
that referenced
this pull request
Dec 8, 2022
|
@Mergifyio backport branch-2.2 branch-2.3 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 4e3418c) # Conflicts: # be/src/exprs/agg/percentile_cont.h
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 4e3418c) # Conflicts: # be/src/exprs/agg/percentile_cont.h
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 4e3418c) # Conflicts: # be/src/exprs/agg/percentile_cont.h
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 4e3418c) # Conflicts: # be/src/exprs/agg/percentile_cont.h
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this：
Which issues of this PR fixes ：
Fixes #14608
Problem Summary(Required) ：
Replace the out-of-place merge with in-place merge to reduce memory allocation overhead.
Benchmark result:
select percentile_cont(lo_orderdate, 0.5) from lineorderwith SSB( scale=100)64s, After is37sChecklist:
Bugfix cherry-pick branch check: