Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix location as reserved keyword bug #17417

Merged
merged 1 commit into from
Feb 6, 2023
Merged

[BugFix] Fix location as reserved keyword bug #17417

merged 1 commit into from
Feb 6, 2023

Conversation

HangyuanLiu
Copy link
Contributor

@HangyuanLiu HangyuanLiu commented Feb 6, 2023 •
edited

introduce by #8940
Signed-off-by: HangyuanLiu 460660596@qq.com

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #17440

Problem Summary(Required) ：

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 2.5
    • 2.4
    • 2.3
    • 2.2

@HangyuanLiu
Fix location as reserved keyword bug
bb07a58 
Signed-off-by: HangyuanLiu <460660596@qq.com>
@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Feb 6, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HangyuanLiu HangyuanLiu added the 2.5 label Feb 6, 2023
@HangyuanLiu HangyuanLiu enabled auto-merge (squash) February 6, 2023 09:03
@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

@HangyuanLiu
Copy link
Contributor Author

run starrocks_admit_test

@HangyuanLiu HangyuanLiu merged commit b625167 into StarRocks:main Feb 6, 2023
@github-actions github-actions bot removed Approved Ready to merge be-build labels Feb 6, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot added 2.5 and removed 2.5 labels Feb 6, 2023
mergify bot pushed a commit that referenced this pull request Feb 6, 2023
@HangyuanLiu @mergify
Fix location as reserved keyword bug (#17417)
1d11e54 
Signed-off-by: HangyuanLiu <460660596@qq.com>
(cherry picked from commit b625167)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4
#	fe/fe-core/src/test/java/com/starrocks/sql/analyzer/AnalyzeSingleTest.java
@mergify mergify bot mentioned this pull request Feb 6, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

backport branch-2.5

✅ Backports have been created

HangyuanLiu added a commit that referenced this pull request Feb 13, 2023
@HangyuanLiu
Fix location as reserved keyword bug (#17417)
35fe77a 
Signed-off-by: HangyuanLiu <460660596@qq.com>
(cherry picked from commit b625167)
Signed-off-by: HangyuanLiu <460660596@qq.com>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4
#	fe/fe-core/src/test/java/com/starrocks/sql/analyzer/AnalyzeSingleTest.java
wanpengfei-git pushed a commit that referenced this pull request Feb 13, 2023
@HangyuanLiu @wanpengfei-git
Fix location as reserved keyword bug (#17417)
05f8782 
Signed-off-by: HangyuanLiu <460660596@qq.com>
(cherry picked from commit b625167)
Signed-off-by: HangyuanLiu <460660596@qq.com>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4
#	fe/fe-core/src/test/java/com/starrocks/sql/analyzer/AnalyzeSingleTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Astralidea Astralidea Astralidea approved these changes

@trueeyu trueeyu trueeyu approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees
No one assigned
Labels
2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Location parse as reserved keyword bug
5 participants
@HangyuanLiu @wanpengfei-git @Astralidea @trueeyu @gengjun-git