Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] optimize storage medium infer when having mixed types #18649

Merged
merged 1 commit into from Mar 1, 2023
Merged

[Enhancement] optimize storage medium infer when having mixed types #18649

merged 1 commit into from Mar 1, 2023

Conversation

nshangyiming
Copy link
Contributor

@nshangyiming nshangyiming commented Feb 28, 2023 •
edited

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #18653

Problem Summary(Required) ：

When storage_medium property is not explicitly specified on creating table, we infer the storage medium type
based on the types of storage paths reported by backends. Here is the rules,

  1. If the storage paths reported by all the backends all have storage medium type HDD,
    we infer that user wants to create a table or partition with storage_medium=HDD.
  2. If the reported storage paths have both SSD type and HDD type, and storage cool down feature is
    not used, we also infer with HDD type.
  3. In other cases, it's SSD type.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@nshangyiming
[Enhancement] optimize storage medium infer when having mixed types
ab51883 
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/DataProperty.java 2 2 100.00% []

@Astralidea Astralidea enabled auto-merge (squash) March 1, 2023 03:05
@nshangyiming
Copy link
Contributor Author

run starrocks_admit_test

1 similar comment
@nshangyiming
Copy link
Contributor Author

run starrocks_admit_test

@Astralidea Astralidea merged commit 9acb8df into StarRocks:main Mar 1, 2023
1 check passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the be-build label Mar 1, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023 •
edited

backport branch-3.0

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Mar 1, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.4

@github-actions github-actions bot removed the 2.4 label Mar 1, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.3

@github-actions github-actions bot removed the 2.3 label Mar 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023 •
edited

backport branch-2.5

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023 •
edited

backport branch-2.4

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023 •
edited

backport branch-2.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 1, 2023
@nshangyiming @mergify
[Enhancement] optimize storage medium infer when having mixed types (#…
962d917 
…18649)

Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)
@mergify mergify bot mentioned this pull request Mar 1, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 1, 2023
@nshangyiming @mergify
[Enhancement] optimize storage medium infer when having mixed types (#…
000c5e1 
…18649)

Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)
@mergify mergify bot mentioned this pull request Mar 1, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 1, 2023
@nshangyiming @mergify
[Enhancement] optimize storage medium infer when having mixed types (#…
d14960f 
…18649)

Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)
mergify bot pushed a commit that referenced this pull request Mar 1, 2023
@nshangyiming @mergify
[Enhancement] optimize storage medium infer when having mixed types (#…
4b6226f 
…18649)

Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)
This was referenced Mar 1, 2023
Merged
Closed
wanpengfei-git pushed a commit that referenced this pull request Mar 2, 2023
@mergify
[Enhancement] optimize storage medium infer when having mixed types (#…
5f135e0 
…18649) (#18735)

optimize storage medium infer when having mixed types
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)
wanpengfei-git pushed a commit that referenced this pull request Mar 2, 2023
@mergify
[Enhancement] optimize storage medium infer when having mixed types (#…
2bd7979 
…18649) (#18736)

optimize storage medium infer when having mixed types 
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
Co-authored-by: yiming <107105845+nshangyiming@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Mar 2, 2023
@mergify
[Enhancement] optimize storage medium infer when having mixed types (#…
af2f93e 
…18649) (#18737)

optimize storage medium infer when having mixed types
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)
nshangyiming pushed a commit to nshangyiming/starrocks that referenced this pull request Mar 29, 2023
@mergify @nshangyiming
[Enhancement] optimize storage medium infer when having mixed types (S…
6857dfb 
…tarRocks#18649) (StarRocks#18737)

optimize storage medium infer when having mixed types
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)
nshangyiming pushed a commit to nshangyiming/starrocks that referenced this pull request Mar 29, 2023
@mergify @nshangyiming
[Enhancement] optimize storage medium infer when having mixed types (S…
6291a7b 
…tarRocks#18649) (StarRocks#18737)

optimize storage medium infer when having mixed types
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)
nshangyiming pushed a commit to nshangyiming/starrocks that referenced this pull request Mar 29, 2023
@mergify @nshangyiming
[Enhancement] optimize storage medium infer when having mixed types (S…
f837804 
…tarRocks#18649) (StarRocks#18737)

optimize storage medium infer when having mixed types
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)
nshangyiming added a commit that referenced this pull request Mar 29, 2023
@nshangyiming @mergify
[Enhancement] optimize storage medium infer when having mixed types (#…
9b2a125 
…18649) (#18737) (#20566)

* [Enhancement] optimize storage medium infer when having mixed types (#18649) (#18737)

optimize storage medium infer when having mixed types
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)

* fix for backport

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nshangyiming added a commit that referenced this pull request Mar 29, 2023
@nshangyiming @mergify
[Enhancement] optimize storage medium infer when having mixed types (#…
1a62b29 
…18649) (#18737) (#20568)

* [Enhancement] optimize storage medium infer when having mixed types (#18649) (#18737)

optimize storage medium infer when having mixed types
Signed-off-by: Dejun Xia <xiadejun@starrocks.com>
(cherry picked from commit 9acb8df)

* fix for backport

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Astralidea Astralidea Astralidea approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees
No one assigned
Labels
3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimize storage medium infer when having mixed types
4 participants
@nshangyiming @wanpengfei-git @Astralidea @gengjun-git