Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Release workgroup token immediately when fragment is cancelled #19310

Merged
merged 2 commits into from Mar 10, 2023
Merged

[BugFix] Release workgroup token immediately when fragment is cancelled #19310

merged 2 commits into from Mar 10, 2023

Conversation

ZiheLiu
Copy link
Contributor

@ZiheLiu ZiheLiu commented Mar 9, 2023 •
edited

What type of PR is this：

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes ：

Fixes #
TODO.

Problem Summary(Required) ：

  1. Release workgroup token immediately when fragment is cancelled.
    Otherwise, it can only be released after query_delivery_timeout (5min by default) sometimes.
  2. Handle error results and cancel fragment instances, excluding TIMEOUT errors, until all the delivered fragment instances are completed.
    Otherwise, the cancellation RPC may arrive at BE before the delivery fragment instance RPC, causing the instances and drivers to become stale and only able to be released after query timeout.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@ZiheLiu
[BugFix] Release workgroup token immediately when fragment is cancelled
3bb1653 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
@mergify mergify bot assigned ZiheLiu Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

mofeiatwork
mofeiatwork previously approved these changes Mar 9, 2023
View reviewed changes
@mofeiatwork mofeiatwork enabled auto-merge (squash) March 10, 2023 02:15
@ZiheLiu
update
83c5719 
Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
@github-actions github-actions bot removed the be-build label Mar 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Mar 10, 2023

run starrocks_be_unittest

1 similar comment
@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Mar 10, 2023

run starrocks_be_unittest

@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Mar 10, 2023

run starrocks_be_unittest

@wanpengfei-git wanpengfei-git added the Approved Ready to merge label Mar 10, 2023
@wanpengfei-git
Copy link
Collaborator

run starrocks_admit_test

@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Mar 10, 2023

run starrocks_fe_unittest

2 similar comments
@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Mar 10, 2023

run starrocks_fe_unittest

@ZiheLiu
Copy link
Contributor Author

ZiheLiu commented Mar 10, 2023

run starrocks_fe_unittest

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😞 fail : 19 / 28 (67.86%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/Coordinator.java 19 28 67.86% [545, 550, 711, 712, 713, 714, 716, 717, 1037]

@mofeiatwork mofeiatwork merged commit 6f0bd88 into StarRocks:main Mar 10, 2023
23 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed Approved Ready to merge 2.5 labels Mar 10, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.4

@github-actions github-actions bot removed the be-build label Mar 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2023 •
edited

backport branch-3.0

✅ Backports have been created

@github-actions github-actions bot removed the 2.4 label Mar 10, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.3

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2023 •
edited

backport branch-2.5

✅ Backports have been created

@github-actions github-actions bot removed the 2.3 label Mar 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2023 •
edited

backport branch-2.4

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2023 •
edited

backport branch-2.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 10, 2023
@ZiheLiu @mergify
[BugFix] Release workgroup token immediately when fragment is cancell…
9a8f741 
…ed (#19310)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
(cherry picked from commit 6f0bd88)
@mergify mergify bot mentioned this pull request Mar 10, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 10, 2023
@ZiheLiu @mergify
[BugFix] Release workgroup token immediately when fragment is cancell…
e842b06 
…ed (#19310)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
(cherry picked from commit 6f0bd88)

# Conflicts:
#	be/src/exec/pipeline/query_context.h
@mergify mergify bot mentioned this pull request Mar 10, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 10, 2023
@ZiheLiu @mergify
[BugFix] Release workgroup token immediately when fragment is cancell…
f9c7dd3 
…ed (#19310)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
(cherry picked from commit 6f0bd88)

# Conflicts:
#	be/src/exec/pipeline/fragment_context.cpp
#	be/src/exec/pipeline/query_context.h
This was referenced Mar 10, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 10, 2023
@ZiheLiu @mergify
[BugFix] Release workgroup token immediately when fragment is cancell…
a154743 
…ed (#19310)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
(cherry picked from commit 6f0bd88)

# Conflicts:
#	be/src/exec/pipeline/fragment_context.cpp
#	be/src/exec/pipeline/query_context.cpp
#	be/src/exec/pipeline/query_context.h
#	be/src/exec/pipeline/scan/scan_operator.cpp
#	fe/fe-core/src/main/java/com/starrocks/qe/Coordinator.java
@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

ZiheLiu pushed a commit that referenced this pull request Mar 14, 2023
@mergify
[BugFix] Release workgroup token immediately when fragment is cancell…
6125799 
…ed (#19310) (#19360)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
ZiheLiu pushed a commit that referenced this pull request Mar 14, 2023
@mergify
[BugFix] Release workgroup token immediately when fragment is cancell…
5f99d0f 
…ed (backport #19310) (#19361)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
ZiheLiu pushed a commit that referenced this pull request Mar 14, 2023
@mergify
[BugFix] Release workgroup token immediately when fragment is cancell…
595320b 
…ed (backport #19310) (#19362)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
ZiheLiu pushed a commit that referenced this pull request Mar 14, 2023
@mergify
[BugFix] Release workgroup token immediately when fragment is cancell…
5e60156 
…ed (backport #19310) (#19363)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Mar 19, 2023
@ZiheLiu @Jay-ju
[BugFix] Release workgroup token immediately when fragment is cancell…
d7cf329 
…ed (StarRocks#19310)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Mar 28, 2023
@ZiheLiu @abc982627271
[BugFix] Release workgroup token immediately when fragment is cancell…
0ab4698 
…ed (StarRocks#19310)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@ZiheLiu
[BugFix] Release workgroup token immediately when fragment is cancell…
8b5cc03 
…ed (StarRocks#19310)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@ZiheLiu @abc982627271
[BugFix] Release workgroup token immediately when fragment is cancell…
9b97925 
…ed (StarRocks#19310)

Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen left review comments

@satanson satanson satanson approved these changes

@mofeiatwork mofeiatwork mofeiatwork approved these changes

Assignees

@ZiheLiu ZiheLiu

Labels
3.0 be-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZiheLiu @wanpengfei-git @satanson @kangkaisen @mofeiatwork