Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] support iso week function (#20511) #22773

Merged
merged 7 commits into from
May 4, 2023
Merged

[Enhancement] support iso week function (#20511) #22773

merged 7 commits into from
May 4, 2023

Conversation

qmengss
Copy link
Contributor

@qmengss qmengss commented Apr 29, 2023 •
edited

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes:

Fixes #22773

Problem Summary(Required):

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto backported to target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

@imay
Copy link
Contributor

imay commented Apr 30, 2023

Thank you for your contribution. Please add documents about this newly added function.

@qmengss
Implement the week_iso function
44e7625 
Signed-off-by: qmengss <707549024@qq.com>
@qmengss
[Enhancement] support iso week function (StarRocks#20511)
8b424dc 
Signed-off-by: qmengss <707549024@qq.com>
@qmengss
[Enhancement] support iso week function (StarRocks#20511)
594d511 
Signed-off-by: qmengss <707549024@qq.com>

Signed-off-by: qmengss <707549024@qq.com>
@qmengss qmengss mentioned this pull request May 1, 2023
Closed
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 1, 2023
@qmengss
[Enhancement] support iso week function (StarRocks#20511)
62f18a6 
${PREPEND:SIGNED-OFF-BY=qmengss<707549024@qq.com>}

Signed-off-by: qmengss <707549024@qq.com>
@qmengss
Copy link
Contributor Author

qmengss commented May 1, 2023

about

doc had add.

imay
imay reviewed May 1, 2023
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you can try writing sql-test which is more convenient. It is in test/ directory

@qmengss
Copy link
Contributor Author

qmengss commented May 1, 2023

let me have a look.

@qmengss
[Enhancement] support iso week function, add sql-test and Simplify th…
7757560 
…e implementation logic. (StarRocks#20511)

Signed-off-by: qmengss <707549024@qq.com>
@qmengss
Copy link
Contributor Author

qmengss commented May 2, 2023

test-sql has added.

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

imay
imay previously approved these changes May 3, 2023
View reviewed changes
@qmengss
[Enhancement] support iso week function, add sql-test null and empty-…
31adca7 
…string case (StarRocks#20511)

Signed-off-by: qmengss <707549024@qq.com>
@LiShuMing
Copy link
Contributor

Well done~ LGTM.

@imay imay merged commit 054b2d6 into StarRocks:main May 4, 2023
16 of 19 checks passed
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request May 10, 2023
@qmengss @xiangguangyxg
[Enhancement] support iso week function (StarRocks#20511) (StarRocks#…
184b152 
…22773)

Signed-off-by: qmengss <707549024@qq.com>
LiShuMing pushed a commit to LiShuMing/starrocks that referenced this pull request May 26, 2023
@qmengss @LiShuMing
[Enhancement] support iso week function (StarRocks#20511) (StarRocks#…
6dcfc84 
…22773)

Signed-off-by: qmengss <707549024@qq.com>
LiShuMing pushed a commit to LiShuMing/starrocks that referenced this pull request May 26, 2023
@qmengss @LiShuMing
[Enhancement] support iso week function (StarRocks#20511) (StarRocks#…
2d859a6 
…22773)

Signed-off-by: Kevin Li <ming.moriarty@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request May 26, 2023
@qmengss @wanpengfei-git
[Enhancement] support iso week function (#20511) (#22773)
4f5d5d7 
Signed-off-by: Kevin Li <ming.moriarty@gmail.com>
numbernumberone pushed a commit to numbernumberone/starrocks that referenced this pull request May 31, 2023
@qmengss
[Enhancement] support iso week function (StarRocks#20511) (StarRocks#…
a01f94f 
…22773)

Signed-off-by: qmengss <707549024@qq.com>
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
@qmengss @abc982627271
[Enhancement] support iso week function (StarRocks#20511) (StarRocks#…
827935c 
…22773)

Signed-off-by: qmengss <707549024@qq.com>
@Youngwb
Copy link
Contributor

Youngwb commented Jun 19, 2023

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2023 •
edited

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 19, 2023
@qmengss @mergify
[Enhancement] support iso week function (#20511) (#22773)
4f25935 
Signed-off-by: qmengss <707549024@qq.com>
(cherry picked from commit 054b2d6)

# Conflicts:
#	test/sql/test_time_fn/R/test_time_fn
#	test/sql/test_time_fn/T/test_time_fn
@mergify mergify bot mentioned this pull request Jun 19, 2023
Closed
Youngwb pushed a commit to Youngwb/starrocks that referenced this pull request Jul 7, 2023
@qmengss @Youngwb
[Enhancement] support iso week function (StarRocks#20511) (StarRocks#…
927d6ee 
…22773)

Signed-off-by: qmengss <707549024@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

Assignees

@qmengss qmengss

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qmengss @imay @wanpengfei-git @LiShuMing @Youngwb