New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] strip debug symbol in release mode #24442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincai
force-pushed
the
strip-be-binary-symbol
branch
from
May 31, 2023 05:45
da6b992
to
7ea1591
Compare
imay
previously approved these changes
May 31, 2023
kevincai
force-pushed
the
strip-be-binary-symbol
branch
3 times, most recently
from
June 2, 2023 02:08
9166036
to
dd83d9e
Compare
* strip debug symbo into separate file, shorten BE process start time Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
kevincai
force-pushed
the
strip-be-binary-symbol
branch
from
June 2, 2023 03:16
dd83d9e
to
62fe3c8
Compare
[FE PR Coverage Check]😍 pass : 0 / 0 (0%) |
imay
approved these changes
Jun 2, 2023
chaoyli
approved these changes
Jun 2, 2023
@Mergifyio backport branch-3.0 |
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
Stripping debug symbol into a separate file, shorten BE process start time (cherry picked from commit bf6f8b8)
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
Stripping debug symbol into a separate file, shorten BE process start time (cherry picked from commit bf6f8b8)
wanpengfei-git
pushed a commit
that referenced
this pull request
Jun 5, 2023
Stripping debug symbol into a separate file, shorten BE process start time (cherry picked from commit bf6f8b8)
wanpengfei-git
pushed a commit
that referenced
this pull request
Jun 5, 2023
Stripping debug symbol into a separate file, shorten BE process start time (cherry picked from commit bf6f8b8)
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 5, 2023
Stripping debug symbol into a separate file, shorten BE process start time
Why is the debug symbol added to the release version? I think debuginfo should be generated when BUILD_TYPE is debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue
What type of PR is this:
Checklist:
Bugfix cherry-pick branch check: