Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] strip debug symbol in release mode #24442

Merged
merged 1 commit into from Jun 2, 2023

Conversation

kevincai
Copy link
Contributor

  • strip debug symbo into separate file, shorten BE process start time

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.0
    • 2.5
    • 2.4
    • 2.3

imay
imay previously approved these changes May 31, 2023
@kevincai kevincai force-pushed the strip-be-binary-symbol branch 3 times, most recently from 9166036 to dd83d9e Compare June 2, 2023 02:08
* strip debug symbo into separate file, shorten BE process start time

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

@chaoyli chaoyli merged commit bf6f8b8 into StarRocks:main Jun 2, 2023
23 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Jun 2, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

backport branch-3.0

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Jun 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 2, 2023
Stripping debug symbol into a separate file, shorten BE process start time

(cherry picked from commit bf6f8b8)
mergify bot pushed a commit that referenced this pull request Jun 2, 2023
Stripping debug symbol into a separate file, shorten BE process start time

(cherry picked from commit bf6f8b8)
@kevincai kevincai deleted the strip-be-binary-symbol branch June 2, 2023 13:33
wanpengfei-git pushed a commit that referenced this pull request Jun 5, 2023
Stripping debug symbol into a separate file, shorten BE process start time

(cherry picked from commit bf6f8b8)
wanpengfei-git pushed a commit that referenced this pull request Jun 5, 2023
Stripping debug symbol into a separate file, shorten BE process start time

(cherry picked from commit bf6f8b8)
abc982627271 pushed a commit to abc982627271/starrocks that referenced this pull request Jun 5, 2023
Stripping debug symbol into a separate file, shorten BE process start time
@Jin-H
Copy link
Contributor

Jin-H commented Sep 1, 2023

Why is the debug symbol added to the release version? I think debuginfo should be generated when BUILD_TYPE is debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants