Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] remove primary index entry when apply rowset failed #27488

Merged
merged 2 commits into from Aug 1, 2023

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Jul 18, 2023

If primary key tablet apply rowset failed, we should remove primary index cache to release memory. This pr remove primary index cache when apply rowset failed.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@sevev
Copy link
Contributor Author

sevev commented Jul 19, 2023

@mergify rebase main

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

rebase main

✅ Branch has been successfully rebased

@sevev sevev enabled auto-merge (squash) August 1, 2023 02:38
@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

@sevev sevev merged commit 7c9533e into StarRocks:main Aug 1, 2023
24 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Aug 1, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

backport branch-3.1

✅ Backports have been created

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 1, 2023
If primary key tablet apply rowset failed, we should remove primary
index cache to release memory. This pr remove primary index cache when
apply rowset failed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 7c9533e)
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
If primary key tablet apply rowset failed, we should remove primary
index cache to release memory. This pr remove primary index cache when
apply rowset failed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 7c9533e)

# Conflicts:
#	be/src/storage/tablet_updates.cpp
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
If primary key tablet apply rowset failed, we should remove primary
index cache to release memory. This pr remove primary index cache when
apply rowset failed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 7c9533e)
sevev added a commit to sevev/starrocks that referenced this pull request Jan 4, 2024
…ks#27488)

If primary key tablet apply rowset failed, we should remove primary
index cache to release memory. This pr remove primary index cache when
apply rowset failed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
sevev added a commit that referenced this pull request Jan 4, 2024
sevev added a commit that referenced this pull request Jan 4, 2024
sevev added a commit to sevev/starrocks that referenced this pull request Jan 4, 2024
…ks#27488)

If primary key tablet apply rowset failed, we should remove primary
index cache to release memory. This pr remove primary index cache when
apply rowset failed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
sevev added a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants