New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] remove primary index entry when apply rowset failed #27488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mergify rebase main |
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
✅ Branch has been successfully rebased |
sevev
force-pushed
the
refactor_error_return
branch
from
July 19, 2023 12:16
22a3a9f
to
8e1c3d1
Compare
chaoyli
approved these changes
Jul 27, 2023
decster
approved these changes
Jul 28, 2023
[FE PR Coverage Check]😍 pass : 0 / 0 (0%) |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
If primary key tablet apply rowset failed, we should remove primary index cache to release memory. This pr remove primary index cache when apply rowset failed. Signed-off-by: zhangqiang <qiangzh95@gmail.com> (cherry picked from commit 7c9533e)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
If primary key tablet apply rowset failed, we should remove primary index cache to release memory. This pr remove primary index cache when apply rowset failed. Signed-off-by: zhangqiang <qiangzh95@gmail.com> (cherry picked from commit 7c9533e) # Conflicts: # be/src/storage/tablet_updates.cpp
mergify bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
If primary key tablet apply rowset failed, we should remove primary index cache to release memory. This pr remove primary index cache when apply rowset failed. Signed-off-by: zhangqiang <qiangzh95@gmail.com> (cherry picked from commit 7c9533e)
3 tasks
sevev
added a commit
to sevev/starrocks
that referenced
this pull request
Jan 4, 2024
…ks#27488) If primary key tablet apply rowset failed, we should remove primary index cache to release memory. This pr remove primary index cache when apply rowset failed. Signed-off-by: zhangqiang <qiangzh95@gmail.com>
sevev
added a commit
to sevev/starrocks
that referenced
this pull request
Jan 4, 2024
…ks#27488) If primary key tablet apply rowset failed, we should remove primary index cache to release memory. This pr remove primary index cache when apply rowset failed. Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If primary key tablet apply rowset failed, we should remove primary index cache to release memory. This pr remove primary index cache when apply rowset failed.
What type of PR is this:
Checklist:
Bugfix cherry-pick branch check: