Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] BE crashed when get tablet stats in shared data mode #29930

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[BugFix] BE crashed when get tablet stats in shared data mode #29930

merged 1 commit into from
Aug 25, 2023

Conversation

sduzh
Copy link
Contributor

@sduzh sduzh commented Aug 25, 2023 •
edited by jaogoy

Make sure the bthread::Mutex will not be destroyed before unlocked.

Fixes #29929

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.1
    • 3.0
    • 2.5
    • 2.4

@mergify mergify bot assigned sduzh Aug 25, 2023
@sduzh sduzh requested review from kevincai and wyb August 25, 2023 04:06
@sduzh
[BugFix] BE crashed when get tablet stats in shared data mode
5401d0a 
Make sure the bthread::Mutex will not be destroyed before unlocked

Fixes StarRocks#29929

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
@sduzh sduzh enabled auto-merge (squash) August 25, 2023 04:14
@sduzh sduzh merged commit 824a4c4 into StarRocks:main Aug 25, 2023
28 of 29 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Aug 25, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Aug 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023 •
edited

backport branch-3.1

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023 •
edited

backport branch-3.0

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request Aug 25, 2023
@sduzh @mergify
[BugFix] BE crashed when get tablet stats in shared data mode (#29930)
da73a5c 
Make sure the bthread::Mutex will not be destroyed before unlocked

Fixes #29929

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 824a4c4)
mergify bot pushed a commit that referenced this pull request Aug 25, 2023
@sduzh @mergify
[BugFix] BE crashed when get tablet stats in shared data mode (#29930)
209e256 
Make sure the bthread::Mutex will not be destroyed before unlocked

Fixes #29929

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 824a4c4)

# Conflicts:
#	be/src/service/service_be/lake_service.cpp
#	be/test/service/lake_service_test.cpp
@mergify mergify bot mentioned this pull request Aug 25, 2023
Merged
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 39 / 42 (92.86%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/QueryQueueManager.java 0 3 00.00% [68, 81, 106]
🔵 com/starrocks/metric/ResourceGroupMetricMgr.java 39 39 100.00% []

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😞 fail : 8 / 13 (61.54%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/service/service_be/lake_service.cpp 8 13 61.54% [401, 603, 634, 704, 728]

@sduzh sduzh deleted the bugfix/issue29929 branch August 25, 2023 07:13
wanpengfei-git pushed a commit that referenced this pull request Aug 25, 2023
@sduzh @wanpengfei-git
[BugFix] BE crashed when get tablet stats in shared data mode (#29930)
66f2ecf 
Make sure the bthread::Mutex will not be destroyed before unlocked

Fixes #29929

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 824a4c4)
wanpengfei-git pushed a commit that referenced this pull request Aug 25, 2023
@sduzh @wanpengfei-git
[BugFix] BE crashed when get tablet stats in shared data mode (#29930)
7e4b4f1 
Make sure the bthread::Mutex will not be destroyed before unlocked

Fixes #29929

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
(cherry picked from commit 824a4c4)

# Conflicts:
#	be/src/service/service_be/lake_service.cpp
#	be/test/service/lake_service_test.cpp
Jay-ju pushed a commit to Jay-ju/starrocks that referenced this pull request Sep 7, 2023
@sduzh @Jay-ju
[BugFix] BE crashed when get tablet stats in shared data mode (StarRo…
9178cd6 
…cks#29930)

Make sure the bthread::Mutex will not be destroyed before unlocked

Fixes StarRocks#29929

Signed-off-by: Alex Zhu <zhuming9011@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

@wyb wyb wyb approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@sduzh sduzh

Labels
3.0 3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BE crashed in shared data mode
5 participants
@sduzh @wanpengfei-git @kevincai @wyb @gengjun-git