Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix mv on non-partitioned jdbc table #31177

Merged
merged 3 commits into from
Sep 18, 2023
Merged

[BugFix] fix mv on non-partitioned jdbc table #31177

merged 3 commits into from
Sep 18, 2023

Conversation

mofeiatwork
Copy link
Contributor

@mofeiatwork mofeiatwork commented Sep 15, 2023 •
edited

Fixes #issue

For non-partitioned mysql external table, its partition_name is null in MySQL schema, we should consider it individually.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mofeiatwork
fix non-partitioned jdbc table
84b5c24 
Signed-off-by: Murphy <mofei@starrocks.com>
@mofeiatwork
fix test
2910a10 
Signed-off-by: Murphy <mofei@starrocks.com>
@mofeiatwork mofeiatwork enabled auto-merge (squash) September 15, 2023 09:01
@mofeiatwork
fix test
e8bb880 
Signed-off-by: Murphy <mofei@starrocks.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.4% 0.4% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 10 / 10 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/jdbc/MysqlSchemaResolver.java 8 8 100.00% []
🔵 com/starrocks/connector/PartitionUtil.java 2 2 100.00% []

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@mofeiatwork mofeiatwork merged commit 9d71c91 into StarRocks:main Sep 18, 2023
41 of 42 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 18, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2023 •
edited

backport branch-3.2

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2023 •
edited

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 18, 2023
@mofeiatwork @mergify
[BugFix] fix mv on non-partitioned jdbc table (#31177)
be8b58c 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 9d71c91)
@mergify mergify bot mentioned this pull request Sep 18, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
@mofeiatwork @mergify
[BugFix] fix mv on non-partitioned jdbc table (#31177)
bcb00ca 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 9d71c91)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/connector/PartitionUtil.java
#	fe/fe-core/src/main/java/com/starrocks/connector/jdbc/MysqlSchemaResolver.java
#	fe/fe-core/src/test/java/com/starrocks/connector/jdbc/MysqlSchemaResolverTest.java
@mergify mergify bot mentioned this pull request Sep 18, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Sep 18, 2023
@mofeiatwork @wanpengfei-git
[BugFix] fix mv on non-partitioned jdbc table (#31177)
4bfcd7e 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 9d71c91)
mofeiatwork added a commit that referenced this pull request Nov 28, 2023
@mofeiatwork
[BugFix] fix mv on non-partitioned jdbc table (#31177)
3780cfa 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 9d71c91)
mofeiatwork added a commit that referenced this pull request Nov 28, 2023
@mofeiatwork
[BugFix] fix mv on non-partitioned jdbc table (#31177)
e02119a 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 9d71c91)
wanpengfei-git pushed a commit that referenced this pull request Nov 28, 2023
@mofeiatwork @wanpengfei-git
[BugFix] fix mv on non-partitioned jdbc table (#31177)
58044a9 
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 9d71c91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@ABingHuang ABingHuang ABingHuang approved these changes

Assignees

@mofeiatwork mofeiatwork

Labels
backport_ok sig/materialized view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mofeiatwork @wanpengfei-git @satanson @ABingHuang