Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix synchronized materialized view with upper column names #31505

Merged
merged 3 commits into from
Oct 10, 2023
Merged

[BugFix] Fix synchronized materialized view with upper column names #31505

merged 3 commits into from
Oct 10, 2023

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Sep 20, 2023 •
edited

Fix #31504

  • synchronized materialized view should be case sensitive for base table's column names.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing
Fix synchronized materialized view with upper column names
6dd8e6e 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing
fix bugs
73e55c4 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@LiShuMing
fix bugs
205adf2 
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
1.7% 1.7% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/ast/CreateMaterializedViewStmt.java 7 7 100.00% []

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@mofeiatwork mofeiatwork enabled auto-merge (squash) October 9, 2023 02:10
@kangkaisen kangkaisen merged commit 151dd89 into StarRocks:main Oct 10, 2023
38 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 10, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023 •
edited

backport branch-3.2

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023 •
edited

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 10, 2023
@LiShuMing @mergify
[BugFix] Fix synchronized materialized view with upper column names (#…
f24da72 
…31505)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 151dd89)
@mergify mergify bot mentioned this pull request Oct 10, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 10, 2023
@LiShuMing @mergify
[BugFix] Fix synchronized materialized view with upper column names (#…
6dc806a 
…31505)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 151dd89)
@mergify mergify bot mentioned this pull request Oct 10, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Oct 15, 2023
@LiShuMing @wanpengfei-git
[BugFix] Fix synchronized materialized view with upper column names (#…
ab1e542 
…31505)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 151dd89)
wanpengfei-git pushed a commit that referenced this pull request Oct 15, 2023
@LiShuMing @wanpengfei-git
[BugFix] Fix synchronized materialized view with upper column names (#…
ab06e43 
…31505)

Signed-off-by: shuming.li <ming.moriarty@gmail.com>
(cherry picked from commit 151dd89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyehcf liuyehcf liuyehcf approved these changes

@mofeiatwork mofeiatwork mofeiatwork approved these changes

@ABingHuang ABingHuang ABingHuang approved these changes

Assignees

@LiShuMing LiShuMing

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Result of synchronized materialized view with upper column names of the base table is wrong
6 participants
@LiShuMing @wanpengfei-git @liuyehcf @mofeiatwork @ABingHuang @kangkaisen