Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] thirdparty build bump POSIX to 200112L #31667

Merged
merged 1 commit into from Sep 23, 2023
Merged

[BugFix] thirdparty build bump POSIX to 200112L #31667

merged 1 commit into from Sep 23, 2023

Conversation

kevincai
Copy link
Contributor

  • get a better compatibility with glibc >=2.22
  • let libcurl find the correct thread safe version of getaddrinfo refer to the man getaddrinfo on ubuntu22.04
  Since glibc 2.22: _POSIX_C_SOURCE >= 200112L
  Glibc 2.21 and earlier: _POSIX_C_SOURCE

Fixes #31663

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai
[BugFix] thirdparty build bump POSIX to 200112L
86819a8 
* get a better compatibility with glibc >=2.22
* let libcurl find the correct thread safe version of `getaddrinfo`
  refer to the `man getaddrinfo` on ubuntu22.04

```
  Since glibc 2.22: _POSIX_C_SOURCE >= 200112L
  Glibc 2.21 and earlier: _POSIX_C_SOURCE
```

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@imay imay merged commit b5de33a into StarRocks:main Sep 23, 2023
32 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 23, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 23, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Sep 23, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Sep 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2023 •
edited

backport branch-3.2

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2023 •
edited

backport branch-3.1

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2023 •
edited

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2023 •
edited

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 23, 2023
@kevincai @mergify
[BugFix] thirdparty build bump POSIX to 200112L (#31667)
fc84014 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit b5de33a)

# Conflicts:
#	thirdparty/build-thirdparty.sh
mergify bot pushed a commit that referenced this pull request Sep 23, 2023
@kevincai @mergify
[BugFix] thirdparty build bump POSIX to 200112L (#31667)
5fd0761 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit b5de33a)

# Conflicts:
#	thirdparty/build-thirdparty.sh
@mergify mergify bot mentioned this pull request Sep 23, 2023
Merged
mergify bot pushed a commit that referenced this pull request Sep 23, 2023
@kevincai @mergify
[BugFix] thirdparty build bump POSIX to 200112L (#31667)
a0a7026 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit b5de33a)
This was referenced Sep 23, 2023
Closed
Closed
mergify bot pushed a commit that referenced this pull request Sep 23, 2023
@kevincai @mergify
[BugFix] thirdparty build bump POSIX to 200112L (#31667)
bb59e02 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit b5de33a)

# Conflicts:
#	thirdparty/build-thirdparty.sh
@mergify mergify bot mentioned this pull request Sep 23, 2023
Closed
@kevincai kevincai mentioned this pull request Sep 24, 2023
Merged
22 tasks
kevincai added a commit to kevincai/starrocks that referenced this pull request Sep 24, 2023
@kevincai
[BugFix] thirdparty build bump POSIX to 200112L (StarRocks#31667)
f9b2121 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit b5de33a)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
kevincai added a commit to kevincai/starrocks that referenced this pull request Sep 24, 2023
@kevincai
[BugFix] thirdparty build bump POSIX to 200112L (StarRocks#31667)
b6f4a6f 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit b5de33a)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai kevincai mentioned this pull request Sep 24, 2023
Merged
22 tasks
kevincai added a commit to kevincai/starrocks that referenced this pull request Sep 24, 2023
@kevincai
[BugFix] thirdparty build bump POSIX to 200112L (StarRocks#31667)
d0a4956 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit b5de33a)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Sep 24, 2023
@kevincai @wanpengfei-git
[BugFix] thirdparty build bump POSIX to 200112L (#31667)
0c34048 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit b5de33a)
imay pushed a commit that referenced this pull request Sep 24, 2023
@kevincai
[BugFix] thirdparty build bump POSIX to 200112L (#31667) (#31675)
6aa4682 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
imay pushed a commit that referenced this pull request Sep 24, 2023
@kevincai
[BugFix] thirdparty build bump POSIX to 200112L (#31667) (#31676)
308f340 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
imay pushed a commit that referenced this pull request Sep 24, 2023
@kevincai
[BugFix] thirdparty build bump POSIX to 200112L (#31667) (#31677)
66767c5 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai kevincai mentioned this pull request Oct 9, 2023
Merged
22 tasks
@kevincai kevincai deleted the fix-posix-c-source-version branch October 13, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

Assignees

@kevincai kevincai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE Crash] BE core in libcurl
3 participants
@kevincai @wanpengfei-git @imay