Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix pindex read-write concurrency between commit and apply #33220

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[BugFix] Fix pindex read-write concurrency between commit and apply #33220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 7 additions & 6 deletions be/src/storage/persistent_index.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4509,14 +4509,15 @@ Status PersistentIndex::_merge_compaction_advance() {
RETURN_IF_ERROR(writer->finish());
std::vector<std::unique_ptr<ImmutableIndex>> new_l1_vec;
std::vector<int> new_l1_merged_num;
size_t merge_num = _l1_merged_num[merge_l1_start_idx];
for (int i = 0; i < merge_l1_start_idx; i++) {
new_l1_vec.emplace_back(std::move(_l1_vec[i]));
new_l1_merged_num.emplace_back(_l1_merged_num[i]);
}

size_t merge_num = 0;
{
std::unique_lock wrlock(_lock);
merge_num = _l1_merged_num[merge_l1_start_idx];
for (int i = 0; i < merge_l1_start_idx; i++) {
new_l1_vec.emplace_back(std::move(_l1_vec[i]));
new_l1_merged_num.emplace_back(_l1_merged_num[i]);
}

for (int i = merge_l1_start_idx; i < _l1_vec.size(); i++) {
_l1_vec[i]->destroy();
}
Expand Down