Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix pindex read-write concurrency between commit and apply #33220

Merged
merged 1 commit into from Oct 20, 2023
Merged

[BugFix] Fix pindex read-write concurrency between commit and apply #33220

merged 1 commit into from Oct 20, 2023

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Oct 20, 2023 •
edited

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sevev
BugFix: Fix pindex read/write conflict between commit and apply
05674f7 
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@mergify mergify bot assigned sevev Oct 20, 2023
@github-actions github-actions bot added the 2.5 label Oct 20, 2023
@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/persistent_index.cpp 5 5 100.00% []

@decster decster merged commit 6bf3e88 into StarRocks:main Oct 20, 2023
48 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 20, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 20, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023 •
edited

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Oct 20, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023 •
edited

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Oct 20, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023 •
edited

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023 •
edited

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 20, 2023
@sevev @mergify
[BugFix] Fix pindex read-write concurrency between commit and apply (#…
820f477 
…33220)

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 6bf3e88)
@mergify mergify bot mentioned this pull request Oct 20, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
@sevev @mergify
[BugFix] Fix pindex read-write concurrency between commit and apply (#…
edf51e4 
…33220)

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 6bf3e88)
This was referenced Oct 20, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
@sevev @mergify
[BugFix] Fix pindex read-write concurrency between commit and apply (#…
b683fc4 
…33220)

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 6bf3e88)
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
@sevev @mergify
[BugFix] Fix pindex read-write concurrency between commit and apply (#…
d91431e 
…33220)

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 6bf3e88)
@mergify mergify bot mentioned this pull request Oct 20, 2023
Merged
wanpengfei-git pushed a commit that referenced this pull request Oct 20, 2023
@sevev @wanpengfei-git
[BugFix] Fix pindex read-write concurrency between commit and apply (#…
94a3c77 
…33220)

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 6bf3e88)
wanpengfei-git pushed a commit that referenced this pull request Oct 20, 2023
@sevev @wanpengfei-git
[BugFix] Fix pindex read-write concurrency between commit and apply (#…
38df2a4 
…33220)

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 6bf3e88)
wanpengfei-git pushed a commit that referenced this pull request Oct 20, 2023
@sevev @wanpengfei-git
[BugFix] Fix pindex read-write concurrency between commit and apply (#…
f29fab6 
…33220)

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 6bf3e88)
wanpengfei-git pushed a commit that referenced this pull request Oct 20, 2023
@sevev @wanpengfei-git
[BugFix] Fix pindex read-write concurrency between commit and apply (#…
8550ddc 
…33220)

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 6bf3e88)
mofeiatwork pushed a commit to mofeiatwork/starrocks that referenced this pull request Oct 23, 2023
@sevev @mofeiatwork
[BugFix] Fix pindex read-write concurrency between commit and apply (S…
9f38d82 
…tarRocks#33220)

During the execution of apply on the primary key table, the apply thread maybe clear or modify _l1_vec of persistent index.
And during the execution commit, the commit thread will update primary index memory usage and need to access _l1_vec.
So there are read/write conflicts between apply thread and commit thread which may cause BE crash. And we add _lock to prevent the read-write concurrency in previous pr but there are some scenarios where locks were inadvertently missed.

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit 6bf3e88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decster decster decster approved these changes

@chaoyli chaoyli chaoyli approved these changes

Assignees

@sevev sevev

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sevev @wanpengfei-git @decster @chaoyli