-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] fix concurrency modify propertyInfo in empty PhysicalPropertySet #34140
Merged
satanson
merged 1 commit into
StarRocks:branch-3.2
from
packy92:branch-3.2_fix_propertyinfo
Nov 1, 2023
Merged
[BugFix] fix concurrency modify propertyInfo in empty PhysicalPropertySet #34140
satanson
merged 1 commit into
StarRocks:branch-3.2
from
packy92:branch-3.2_fix_propertyinfo
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ySet Signed-off-by: packy <wangchao@starrocks.com>
[FE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
satanson
approved these changes
Nov 1, 2023
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
This was referenced Nov 1, 2023
Merged
Closed
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue
Fix stack like this
The root cause is
may return PhysicalPropertySet.EMPTY and we may update the PropertyInfo in
DistributionProperty.EMPTY
in the nextcomputeHashJoinDistributionPropertyInfo()
step which may concurrent modify a static object at the same time.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: