Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix concurrency modify propertyInfo in empty PhysicalPropertySet #34140

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

packy92
Copy link
Contributor

@packy92 packy92 commented Nov 1, 2023

Fixes #issue
Fix stack like this

java.util.ConcurrentModificationException: null
        at java.util.HashMap.computeIfAbsent(HashMap.java:1134) ~[?:?]
        at com.starrocks.sql.optimizer.base.DistributionDisjointSet.find(DistributionDisjointSet.java:55) ~[starrocks-fe.jar:?]
        at com.starrocks.sql.optimizer.base.DistributionDisjointSet.union(DistributionDisjointSet.java:74) ~[starrocks-fe.jar:?]
        at com.starrocks.sql.optimizer.base.DistributionSpec$PropertyInfo.unionDistributionCols(DistributionSpec.java:93) ~[starrocks-fe.jar:?]
        

The root cause is

private PhysicalPropertySet computeShuffleJoinOutputProperty(JoinOperator joinType,
                                                                 List<DistributionCol> leftShuffleColumns,
                                                                 List<DistributionCol> rightShuffleColumns) {
        Optional<HashDistributionDesc> requiredShuffleDesc = getRequiredShuffleDesc();
        if (!requiredShuffleDesc.isPresent()) {
            return PhysicalPropertySet.EMPTY;
        }
}

may return PhysicalPropertySet.EMPTY and we may update the PropertyInfo in DistributionProperty.EMPTY in the next computeHashJoinDistributionPropertyInfo() step which may concurrent modify a static object at the same time.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

…ySet

Signed-off-by: packy <wangchao@starrocks.com>
Copy link

github-actions bot commented Nov 1, 2023

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/OutputPropertyDeriver.java 2 2 100.00% []

Copy link

github-actions bot commented Nov 1, 2023

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@satanson satanson merged commit b3cfde4 into StarRocks:branch-3.2 Nov 1, 2023
62 checks passed
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 1, 2023
@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Nov 1, 2023
Copy link
Contributor

mergify bot commented Nov 1, 2023

backport branch-3.1

✅ Backports have been created

@wanpengfei-git
Copy link
Collaborator

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Nov 1, 2023
Copy link
Contributor

mergify bot commented Nov 1, 2023

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 1, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 1, 2023
…ySet (#34140)

Signed-off-by: packy <wangchao@starrocks.com>
(cherry picked from commit b3cfde4)
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
…ySet (#34140)

Signed-off-by: packy <wangchao@starrocks.com>
(cherry picked from commit b3cfde4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OutputPropertyDeriver.java
mergify bot pushed a commit that referenced this pull request Nov 1, 2023
…ySet (#34140)

Signed-off-by: packy <wangchao@starrocks.com>
(cherry picked from commit b3cfde4)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OutputPropertyDeriver.java
wanpengfei-git pushed a commit that referenced this pull request Nov 1, 2023
…ySet (#34140)

Signed-off-by: packy <wangchao@starrocks.com>
(cherry picked from commit b3cfde4)
mergify bot pushed a commit that referenced this pull request Nov 28, 2023
…ySet (#34140)

Signed-off-by: packy <wangchao@starrocks.com>
(cherry picked from commit b3cfde4)
(cherry picked from commit 8d31f23)
imay pushed a commit that referenced this pull request Nov 28, 2023
…ySet (backport #34140) (backport #34146) (#35901)

Co-authored-by: packy92 <110370499+packy92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants