[BugFix] Fix iceberg position delete bug in orc format #34682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Smith Cruise <chendingchao1@126.com>
letian-jiang
approved these changes
Nov 9, 2023
GavinMar
reviewed
Nov 9, 2023
| @@ -1161,7 +1161,7 @@ ColumnPtr OrcChunkReader::get_row_delete_filter(const std::set<int64_t>& deleted | |||
| ColumnPtr filter_column = BooleanColumn::create(num_rows, 1); | |||
| auto& filter = static_cast<BooleanColumn*>(filter_column.get())->get_data(); | |||
| auto iter = deleted_pos.lower_bound(start_pos); | |||
| auto end = deleted_pos.upper_bound(start_pos + num_rows); | |||
| auto end = deleted_pos.upper_bound(start_pos + num_rows - 1); | |||
There was a problem hiding this comment.
Is it posible that the start_pos and num_rows are 0 ?
There was a problem hiding this comment.
before call get_row_delete_filter(), we will call _orc_reader->read_next() first. If num_rows is 0, read_next() function will return EOF directly, the code can't go here.
There was a problem hiding this comment.
before call
get_row_delete_filter(), we will call_orc_reader->read_next()first. If num_rows is 0,read_next()function will return EOF directly, the code can't go here.
OK
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 14 / 21 (66.67%) file detail
|
GavinMar
approved these changes
Nov 10, 2023
stephen-shelby
approved these changes
Nov 10, 2023
dirtysalt
approved these changes
Nov 10, 2023
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
|
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Smith Cruise <chendingchao1@126.com> (cherry picked from commit fa39811)
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Smith Cruise <chendingchao1@126.com> (cherry picked from commit fa39811) # Conflicts: # be/src/exec/hdfs_scanner.h # be/src/exec/hdfs_scanner_parquet.cpp # be/src/formats/parquet/group_reader.cpp
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Smith Cruise <chendingchao1@126.com> (cherry picked from commit fa39811) # Conflicts: # be/src/exec/hdfs_scanner.h # be/src/exec/hdfs_scanner_orc.cpp # be/src/exec/hdfs_scanner_parquet.cpp # be/src/formats/parquet/group_reader.cpp
22 tasks
22 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Smith Cruise <chendingchao1@126.com> (cherry picked from commit fa39811)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes orc iceberg position delete bug and extract iceberg v2 stats
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: