Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix automatic partition write data into wrong partition when many partition created concurrency #34731

Merged
merged 1 commit into from Nov 10, 2023
Merged

[BugFix] Fix automatic partition write data into wrong partition when many partition created concurrency #34731

merged 1 commit into from Nov 10, 2023

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Nov 10, 2023 •
edited

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@meegoo
[BugFix] Fix automatic partition write data into wrong partition when…
95e9ccf 
… many partition created concurrency

Signed-off-by: meegoo <meegoo.sr@gmail.com>
@mergify mergify bot assigned meegoo Nov 10, 2023
@meegoo meegoo changed the title [BugFix] Fix automatic partition write data into wrong partition when… [BugFix] Fix automatic partition write data into wrong partition when many partition created concurrency Nov 10, 2023
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 1 / 2 (50.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/runtime/local_tablets_channel.cpp 0 1 00.00% [837]
🔵 src/runtime/lake_tablets_channel.cpp 1 1 100.00% []

@meegoo meegoo marked this pull request as ready for review November 10, 2023 07:01
@meegoo meegoo enabled auto-merge (squash) November 10, 2023 07:01
@meegoo meegoo merged commit 2095a85 into StarRocks:main Nov 10, 2023
96 of 108 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 10, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 10, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Nov 10, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 10, 2023 •
edited

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@meegoo @mergify
[BugFix] Fix automatic partition write data into wrong partition when…
3dc7205 
… many partition created concurrency (#34731)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit 2095a85)
@mergify mergify bot mentioned this pull request Nov 10, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@meegoo @mergify
[BugFix] Fix automatic partition write data into wrong partition when…
eb03a78 
… many partition created concurrency (#34731)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit 2095a85)

# Conflicts:
#	be/src/runtime/lake_tablets_channel.cpp
@mergify mergify bot mentioned this pull request Nov 10, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 10, 2023
@meegoo @mergify
[BugFix] Fix automatic partition write data into wrong partition when…
37c9802 
… many partition created concurrency (#34731)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit 2095a85)
@mergify mergify bot mentioned this pull request Nov 10, 2023
Merged
meegoo added a commit that referenced this pull request Nov 10, 2023
@mergify @meegoo
[BugFix] Fix automatic partition write data into wrong partition when…
045c61c 
… many partition created concurrency (backport #34731) (#34763)

Co-authored-by: meegoo <meegoo.sr@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@meegoo @wanpengfei-git
[BugFix] Fix automatic partition write data into wrong partition when…
1cd3343 
… many partition created concurrency (#34731)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit 2095a85)
wanpengfei-git pushed a commit that referenced this pull request Nov 10, 2023
@meegoo @wanpengfei-git
[BugFix] Fix automatic partition write data into wrong partition when…
33fb330 
… many partition created concurrency (#34731)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit 2095a85)
meegoo added a commit to meegoo/starrocks that referenced this pull request Nov 15, 2023
@meegoo
[BugFix] Fix automatic partition write data into wrong partition when…
0f0817d 
… many partition created concurrency (StarRocks#34731)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
stdpain pushed a commit to stdpain/starrocks-2 that referenced this pull request Nov 22, 2023
@meegoo @stdpain
[BugFix] Fix automatic partition write data into wrong partition when…
8555986 
… many partition created concurrency (StarRocks#34731)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
mergify bot pushed a commit that referenced this pull request Nov 28, 2023
@meegoo @mergify
[BugFix] Fix automatic partition write data into wrong partition when…
5387ffb 
… many partition created concurrency (#34731)

Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit 2095a85)
(cherry picked from commit 1cd3343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@sduzh sduzh sduzh left review comments

@kevincai kevincai kevincai approved these changes

@Astralidea Astralidea Astralidea approved these changes

Assignees

@meegoo meegoo

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@meegoo @kevincai @wyb @sduzh @Astralidea @wanpengfei-git