Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] make lake pk compaction upper threshold configurable #35129

Merged
merged 1 commit into from Nov 17, 2023
Merged

[Enhancement] make lake pk compaction upper threshold configurable #35129

merged 1 commit into from Nov 17, 2023

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Nov 15, 2023

Why I'm doing:
Now we limit the max lake pk compaction output bytes under max(update_compaction_result_bytes, 1/2 * tablet bytes), make this ratio(1/2) configurable to prevent bad case.

What I'm doing:
Add config update_compaction_ratio_threshold.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions github-actions bot added the 3.2 label Nov 15, 2023
@github-actions github-actions bot added the 3.1 label Nov 15, 2023
wyb
wyb previously approved these changes Nov 16, 2023
View reviewed changes
sduzh
sduzh previously approved these changes Nov 16, 2023
View reviewed changes
@sduzh sduzh enabled auto-merge (squash) November 16, 2023 02:10
@luohaha
[Enhancement] make lake pk compaction upper threshold configurable
f420cff 
Signed-off-by: luohaha <18810541851@163.com>

Signed-off-by: luohaha <18810541851@163.com>
auto-merge was automatically disabled November 16, 2023 19:05

Head branch was pushed to by a user without write access

@luohaha luohaha dismissed stale reviews from sduzh and wyb via f420cff November 16, 2023 19:05
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/compaction_policy.cpp 4 4 100.00% []

@sduzh sduzh merged commit a1ac17e into StarRocks:main Nov 17, 2023
52 of 67 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 17, 2023
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 17, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023 •
edited

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023 •
edited

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 17, 2023
@luohaha @mergify
[Enhancement] make lake pk compaction upper threshold configurable (#…
0019512 
…35129)

Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit a1ac17e)
@mergify mergify bot mentioned this pull request Nov 17, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 17, 2023
@luohaha @mergify
[Enhancement] make lake pk compaction upper threshold configurable (#…
1bd9bd4 
…35129)

Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit a1ac17e)

# Conflicts:
#	be/src/storage/lake/compaction_policy.cpp
@mergify mergify bot mentioned this pull request Nov 17, 2023
Closed
@luohaha luohaha mentioned this pull request Nov 18, 2023
Merged
22 tasks
imay pushed a commit that referenced this pull request Nov 18, 2023
@luohaha
[Enhancement] make lake pk compaction upper threshold configurable (b…
cdc7aba 
…ackport #35129)  (#35337)

Why I'm doing:
Now we limit the max lake pk compaction output bytes under max(update_compaction_result_bytes, 1/2 * tablet bytes), make this ratio(1/2) configurable to prevent bad case.

What I'm doing:
Add config update_compaction_ratio_threshold.

backport #35129

Signed-off-by: luohaha <18810541851@163.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 18, 2023
@luohaha @wanpengfei-git
[Enhancement] make lake pk compaction upper threshold configurable (#…
730e472 
…35129)

Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit a1ac17e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@sduzh sduzh sduzh approved these changes

@xiangguangyxg xiangguangyxg xiangguangyxg approved these changes

Assignees

@luohaha luohaha

Labels
backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@luohaha @wyb @sduzh @xiangguangyxg @wanpengfei-git