Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Extend interval type for 'date_trunc', 'days_add', 'time_slice' #36386

Merged
merged 1 commit into from Dec 5, 2023
Merged

[Enhancement] Extend interval type for 'date_trunc', 'days_add', 'time_slice' #36386

merged 1 commit into from Dec 5, 2023

Conversation

liuyehcf
Copy link
Contributor

@liuyehcf liuyehcf commented Dec 4, 2023 •
edited by silverbullet233

Support MILLI SECOND AND MICRO SECOND type interval for function date_trunc/adddate/time_slice

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@liuyehcf
[Enhancement] Extend interval type for 'date_trunc', 'days_add', 'tim…
833f854 
…e_slice'

Signed-off-by: liuyehcf <1559500551@qq.com>
@liuyehcf liuyehcf requested a review from a team as a code owner December 4, 2023 12:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

[BE Incremental Coverage Report]

❌ fail : 21 / 43 (48.84%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/types/timestamp_value.cpp 0 4 00.00% [766, 767, 768, 769]
🔵 be/src/exprs/time_functions.cpp 13 29 44.83% [892, 894, 914, 920, 922, 942, 2470, 2472, 2490, 2492, 2501, 2506, 2507, 2508, 2509, 2511]
🔵 be/src/types/timestamp_value.h 8 10 80.00% [170, 186]

@liuyehcf liuyehcf merged commit 1a00830 into StarRocks:main Dec 5, 2023
61 of 62 checks passed
@liuyehcf
Copy link
Contributor Author

liuyehcf commented Dec 5, 2023

@Mergifyio backport branch-3.2

@github-actions github-actions bot added the 3.2 label Dec 5, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023 •
edited

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 5, 2023
@liuyehcf @mergify
[Enhancement] Extend interval type for 'date_trunc', 'days_add', 'tim…
1bee48c 
…e_slice' (#36386)

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 1a00830)
@mergify mergify bot mentioned this pull request Dec 5, 2023
Merged
liuyehcf added a commit that referenced this pull request Dec 6, 2023
@mergify @liuyehcf
[Enhancement] Extend interval type for 'date_trunc', 'days_add', 'tim…
8c88ace 
…e_slice' (backport #36386) (#36465)

Co-authored-by: liuyehcf <1559500551@qq.com>
dingxin-tech pushed a commit to dingxin-tech/starrocks-odps that referenced this pull request Dec 12, 2023
@liuyehcf @zhangdingxin484
[Enhancement] Extend interval type for 'date_trunc', 'days_add', 'tim…
1a79dd8 
…e_slice' (StarRocks#36386)

Signed-off-by: liuyehcf <1559500551@qq.com>
Signed-off-by: 鼎昕 <zhangdingxin.zdx@alibaba-inc.com>
@silverbullet233
Copy link
Contributor

@mergify backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2023 •
edited

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot added the 3.1 label Dec 25, 2023
mergify bot pushed a commit that referenced this pull request Dec 25, 2023
@liuyehcf @mergify
[Enhancement] Extend interval type for 'date_trunc', 'days_add', 'tim…
4bd58e4 
…e_slice' (#36386)

Signed-off-by: liuyehcf <1559500551@qq.com>
(cherry picked from commit 1a00830)
@mergify mergify bot mentioned this pull request Dec 25, 2023
Merged
17 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2023
@mergify @liuyehcf
[Enhancement] Extend interval type for 'date_trunc', 'days_add', 'tim…
955f90b 
…e_slice' (backport #36386) (#37716)

Co-authored-by: liuyehcf <1559500551@qq.com>
@liuyehcf
Copy link
Contributor Author

version >= 3.1.7 or 3.2.1

@liuyehcf
Copy link
Contributor Author

these functions also supported.

  • adddate
  • date_add
  • subdate
  • date_sub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr left review comments

@silverbullet233 silverbullet233 silverbullet233 approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@liuyehcf liuyehcf

Labels
3.1-merged 3.1 3.2 backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuyehcf @silverbullet233 @kangkaisen @wanpengfei-git