Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement][Branch-3.2] Use G1 GC by default on jdk8 #37268

Merged
merged 3 commits into from Dec 19, 2023
Merged

[Enhancement][Branch-3.2] Use G1 GC by default on jdk8 #37268

merged 3 commits into from Dec 19, 2023

Conversation

Astralidea
Copy link
Contributor

@Astralidea Astralidea commented Dec 18, 2023 •
edited

Why I'm doing:

G1GC performs better in most scenarios, so we should use G1GC as soon as possible.

What I'm doing:

G1GC has a bug in the lower version of JDK8. We will add a WARNING to remind users.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Astralidea
Use G1 GC
1ac8bbe 
Signed-off-by: Astralidea <astralidea@163.com>
nshangyiming
nshangyiming reviewed Dec 19, 2023
View reviewed changes
bin/start_fe.sh Outdated Show resolved Hide resolved
@Astralidea
Opt.
527e7cc 
Signed-off-by: Astralidea <astralidea@163.com>
@Astralidea
Fix.
32357ed 
Signed-off-by: Astralidea <astralidea@163.com>
@nshangyiming nshangyiming changed the title [Enhancement][Branch-3.2] Use G1 GC [Enhancement][Branch-3.2] Use G1 GC by default on jdk8 Dec 19, 2023
@nshangyiming nshangyiming enabled auto-merge (squash) December 19, 2023 03:30
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wanpengfei-git wanpengfei-git merged commit 836af97 into StarRocks:branch-3.2 Dec 19, 2023
28 of 30 checks passed
@Astralidea
Copy link
Contributor Author

https://github.com/Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2023 •
edited

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 19, 2023
@Astralidea @mergify
[Enhancement][Branch-3.2] Use G1 GC by default on jdk8 (#37268)
b2317d8 
Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 836af97)

# Conflicts:
#	conf/fe.conf
@mergify mergify bot mentioned this pull request Dec 19, 2023
Closed
18 tasks
Astralidea added a commit that referenced this pull request Dec 19, 2023
@Astralidea
[Enhancement] Use G1 GC by default on jdk8 (backport #37268) (#37380)
41a4465 
Signed-off-by: Astralidea <astralidea@163.com>
mergify bot pushed a commit that referenced this pull request Dec 19, 2023
@Astralidea @mergify
[Enhancement] Use G1 GC by default on jdk8 (backport #37268) (#37380)
f910337 
Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 41a4465)
Astralidea added a commit that referenced this pull request Dec 19, 2023
@mergify @Astralidea
[Enhancement] Use G1 GC by default on jdk8 (backport #37268) (backport …
9a09da6 
…#37380) (#37386)

Co-authored-by: Felix Li <astralidea@163.com>
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
@Astralidea @mergify
[Enhancement] Use G1 GC by default on jdk8 (backport #37268) (#37380)
8a2eca1 
Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 41a4465)
wanpengfei-git pushed a commit that referenced this pull request Dec 21, 2023
@mergify @Astralidea
[Enhancement] Use G1 GC by default on jdk8 (backport #37268) (backport …
8eddb7d 
…#37380) (#37498)

Co-authored-by: Felix Li <astralidea@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshangyiming nshangyiming nshangyiming approved these changes

Assignees

@Astralidea Astralidea

Labels
3.0 3.1 behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Astralidea @nshangyiming @wanpengfei-git