Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] support condition update in broker load #37400

Merged
merged 2 commits into from Dec 20, 2023
Merged

[Feature] support condition update in broker load #37400

merged 2 commits into from Dec 20, 2023

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Dec 20, 2023 •
edited by github-actions bot

Why I'm doing:
No support condition update in broker load yet.

What I'm doing:
Support condition update in broker load

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha
[Feature] support condition update in broker load
8ea2aa4 
Signed-off-by: luohaha <18810541851@163.com>
@github-actions github-actions bot added behavior_changed documentation Improvements or additions to documentation META-REVIEW labels Dec 20, 2023
decster
decster previously approved these changes Dec 20, 2023
View reviewed changes
@luohaha
add fe ut
36ed7ba 
Signed-off-by: luohaha <18810541851@163.com>
@luohaha luohaha force-pushed the support-broker-load-condition branch from 17a6372 to 36ed7ba Compare December 20, 2023 04:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 6 / 7 (85.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/loadv2/LoadLoadingTask.java 0 1 00.00% [138]
🔵 com/starrocks/load/loadv2/LoadJob.java 2 2 100.00% []
🔵 com/starrocks/sql/LoadPlanner.java 4 4 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@decster decster merged commit ad77056 into StarRocks:main Dec 20, 2023
45 checks passed
@luohaha
Copy link
Contributor Author

luohaha commented Dec 20, 2023

https://github.com/Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2023 •
edited

backport branch-3.2

✅ Backports have been created

@luohaha
Copy link
Contributor Author

luohaha commented Dec 20, 2023

https://github.com/Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2023 •
edited

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 20, 2023
@luohaha @mergify
[Feature] support condition update in broker load (#37400)
a5ab630 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit ad77056)
mergify bot pushed a commit that referenced this pull request Dec 20, 2023
@luohaha @mergify
[Feature] support condition update in broker load (#37400)
7a50f6b 
Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit ad77056)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/loadv2/LoadLoadingTask.java
This was referenced Dec 20, 2023
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Dec 20, 2023
@mergify @luohaha
[Feature] support condition update in broker load (backport #37400) (#…
d3314ac 
…37470)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
luohaha added a commit that referenced this pull request Dec 21, 2023
@mergify @luohaha
[Feature] support condition update in broker load (backport #37400) (#…
7fd8594 
…37469)

Co-authored-by: Yixin Luo <18810541851@163.com>
Zhangg7723 pushed a commit to Zhangg7723/starrocks that referenced this pull request Dec 26, 2023
@luohaha @Zhangg7723
[Feature] support condition update in broker load (StarRocks#37400)
10cf860 
Signed-off-by: luohaha <18810541851@163.com>
Signed-off-by: 张敢 <zhanggan@deepexi.com>
@amber-create amber-create mentioned this pull request Jan 15, 2024
Merged
23 tasks
@wanpengfei-git wanpengfei-git mentioned this pull request Jan 15, 2024
Merged
18 tasks
@wanpengfei-git wanpengfei-git mentioned this pull request Jan 15, 2024
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decster decster decster approved these changes

@nshangyiming nshangyiming nshangyiming approved these changes

Assignees

@luohaha luohaha

Labels
backport_ok documentation Improvements or additions to documentation META-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luohaha @decster @nshangyiming @wangruin