Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix the bug of bitmap_to_string overflow #37405

Merged
merged 2 commits into from Dec 20, 2023

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Dec 20, 2023

Why I'm doing:

uint64_t (such as 18446744073709551611) convert to int64_t will be overflow.

What I'm doing:

Use uint64_t instead of int64_t to avoid this implicit type conversion

Fixes #37184

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu trueeyu changed the title [BugFix] Fix the bug of bitmap_to_string overflow [WIP] [BugFix] Fix the bug of bitmap_to_string overflow Dec 20, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com>
@trueeyu trueeyu changed the title [WIP] [BugFix] Fix the bug of bitmap_to_string overflow [BugFix] Fix the bug of bitmap_to_string overflow Dec 20, 2023
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stdpain stdpain merged commit 299165e into StarRocks:main Dec 20, 2023
45 of 46 checks passed
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 20, 2023
Copy link

@Mergifyio backport branch-3.1

Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.1 label Dec 20, 2023
Copy link
Contributor

mergify bot commented Dec 20, 2023

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Dec 20, 2023
Copy link

@Mergifyio backport branch-2.5

Copy link
Contributor

mergify bot commented Dec 20, 2023

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Dec 20, 2023
Copy link
Contributor

mergify bot commented Dec 20, 2023

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 20, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 20, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 299165e)
mergify bot pushed a commit that referenced this pull request Dec 20, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 299165e)
mergify bot pushed a commit that referenced this pull request Dec 20, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 299165e)
Copy link

[BE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/types/bitmap_value.cpp 1 1 100.00% []

mergify bot pushed a commit that referenced this pull request Dec 20, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 299165e)
wanpengfei-git pushed a commit that referenced this pull request Dec 20, 2023
wanpengfei-git pushed a commit that referenced this pull request Dec 21, 2023
wanpengfei-git pushed a commit that referenced this pull request Dec 21, 2023
wanpengfei-git pushed a commit that referenced this pull request Dec 21, 2023
Zhangg7723 pushed a commit to Zhangg7723/starrocks that referenced this pull request Dec 26, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com>
Signed-off-by: 张敢 <zhanggan@deepexi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitmap_agg(largeint)结果变成负数
3 participants