New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix the bug of bitmap_to_string overflow #37405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trueeyu <lxhhust350@qq.com>
trueeyu
changed the title
[BugFix] Fix the bug of bitmap_to_string overflow
[WIP] [BugFix] Fix the bug of bitmap_to_string overflow
Dec 20, 2023
trueeyu
changed the title
[WIP] [BugFix] Fix the bug of bitmap_to_string overflow
[BugFix] Fix the bug of bitmap_to_string overflow
Dec 20, 2023
silverbullet233
approved these changes
Dec 20, 2023
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
stdpain
approved these changes
Dec 20, 2023
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com> (cherry picked from commit 299165e)
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com> (cherry picked from commit 299165e)
18 tasks
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com> (cherry picked from commit 299165e)
18 tasks
[BE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com> (cherry picked from commit 299165e)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 20, 2023
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 21, 2023
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 21, 2023
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 21, 2023
Zhangg7723
pushed a commit
to Zhangg7723/starrocks
that referenced
this pull request
Dec 26, 2023
Signed-off-by: trueeyu <lxhhust350@qq.com> Signed-off-by: 张敢 <zhanggan@deepexi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
uint64_t (such as 18446744073709551611) convert to int64_t will be overflow.
What I'm doing:
Use uint64_t instead of int64_t to avoid this implicit type conversion
Fixes #37184
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: