Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Improve the problem of generating too many small files for partial update column mode (backport #37523) #37588

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[Enhancement] Improve the problem of generating too many small files for partial update column mode (backport #37523) #37588

merged 1 commit into from
Dec 21, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 21, 2023 •
edited by wanpengfei-git

This is an automatic backport of pull request #37523 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Why I'm doing: In previous PR #14187, we limit the memtable row number when handle partial update, but it's useless to column mode and will cause too many small files.

What I'm doing:
No need to limit memtable row number when handle partial update column mode.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@luohaha @mergify
[Enhancement] Improve the problem of generating too many small files …
9e2d502 
…for partial update column mode (#37523)

Signed-off-by: luohaha <18810541851@163.com>
(cherry picked from commit b26b382)
@mergify mergify bot mentioned this pull request Dec 21, 2023
Merged
23 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) December 21, 2023 19:26
@wanpengfei-git wanpengfei-git merged commit 64889dd into branch-3.2 Dec 21, 2023
28 of 29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-37523 branch December 21, 2023 20:18
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 4 / 7 (57.14%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/storage/delta_writer.cpp 4 7 57.14% [226, 227, 231]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luohaha luohaha luohaha approved these changes

Assignees

@luohaha luohaha

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luohaha @wanpengfei-git