New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Routine load task schduling #37638
Conversation
Signed-off-by: ricky <rickif@qq.com>
if (checkReadyToExecuteFast()) { | ||
return true; | ||
} | ||
|
||
KafkaRoutineLoadJob kafkaRoutineLoadJob = (KafkaRoutineLoadJob) routineLoadJob; | ||
Map<Integer, Long> latestOffsets = KafkaUtil.getLatestOffsets(kafkaRoutineLoadJob.getBrokerList(), | ||
kafkaRoutineLoadJob.getTopic(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most risky bug in this code is:
Potential ClassCastException when casting RoutineLoadJob to KafkaRoutineLoadJob without checking its type.
You can modify the code like this:
// Add a type check before casting
if (routineLoadJob instanceof KafkaRoutineLoadJob) {
KafkaRoutineLoadJob kafkaRoutineLoadJob = (KafkaRoutineLoadJob) routineLoadJob;
// existing code continues here...
} else {
// handle the case where it's not an instance of KafkaRoutineLoadJob, possibly throw an exception or return false
}
fe/fe-core/src/main/java/com/starrocks/load/routineload/RoutineLoadTaskScheduler.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/load/routineload/KafkaTaskInfo.java
Show resolved
Hide resolved
Signed-off-by: ricky <rickif@qq.com>
Signed-off-by: ricky <rickif@qq.com>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
[FE Incremental Coverage Report]✅ pass : 14 / 16 (87.50%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
Signed-off-by: ricky <rickif@qq.com> (cherry picked from commit d645805) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/load/routineload/KafkaRoutineLoadJob.java
Signed-off-by: ricky <rickif@qq.com> (cherry picked from commit d645805) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/load/routineload/KafkaRoutineLoadJob.java
Signed-off-by: ricky <rickif@qq.com> (cherry picked from commit d645805) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/load/routineload/KafkaRoutineLoadJob.java
Signed-off-by: ricky <rickif@qq.com> (cherry picked from commit d645805) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/load/routineload/KafkaRoutineLoadJob.java
Signed-off-by: ricky <rickif@qq.com>
Signed-off-by: ricky <rickif@qq.com>
…) (#38303) Signed-off-by: ricky <rickif@qq.com>
…) (#38302) Signed-off-by: ricky <rickif@qq.com>
Why I'm doing:
Now, the routine load task scheduling may be slowed down by some slow tasks.
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: