Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Routine load task schduling #37638

Merged
merged 3 commits into from Jan 2, 2024

Conversation

rickif
Copy link
Contributor

@rickif rickif commented Dec 22, 2023

Why I'm doing:
Now, the routine load task scheduling may be slowed down by some slow tasks.
What I'm doing:

  1. remove the limit of routine load task scheduler threadpool
  2. Quickly determine if a task needs to be scheduled based on local offset information

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: ricky <rickif@qq.com>
if (checkReadyToExecuteFast()) {
return true;
}

KafkaRoutineLoadJob kafkaRoutineLoadJob = (KafkaRoutineLoadJob) routineLoadJob;
Map<Integer, Long> latestOffsets = KafkaUtil.getLatestOffsets(kafkaRoutineLoadJob.getBrokerList(),
kafkaRoutineLoadJob.getTopic(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky bug in this code is:
Potential ClassCastException when casting RoutineLoadJob to KafkaRoutineLoadJob without checking its type.

You can modify the code like this:

// Add a type check before casting
if (routineLoadJob instanceof KafkaRoutineLoadJob) {
    KafkaRoutineLoadJob kafkaRoutineLoadJob = (KafkaRoutineLoadJob) routineLoadJob;
    // existing code continues here...
} else {
    // handle the case where it's not an instance of KafkaRoutineLoadJob, possibly throw an exception or return false
}

Signed-off-by: ricky <rickif@qq.com>
Signed-off-by: ricky <rickif@qq.com>
Copy link

sonarcloud bot commented Dec 27, 2023

Copy link

[FE Incremental Coverage Report]

pass : 14 / 16 (87.50%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/routineload/KafkaTaskInfo.java 12 14 85.71% [101, 125]
🔵 com/starrocks/load/routineload/RoutineLoadTaskScheduler.java 1 1 100.00% []
🔵 com/starrocks/load/routineload/KafkaRoutineLoadJob.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@meegoo meegoo enabled auto-merge (squash) January 2, 2024 18:37
@meegoo meegoo merged commit d645805 into StarRocks:main Jan 2, 2024
48 checks passed
Copy link

github-actions bot commented Jan 2, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

@Mergifyio backport branch-3.1

Copy link

github-actions bot commented Jan 2, 2024

@Mergifyio backport branch-3.0

Copy link

github-actions bot commented Jan 2, 2024

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Jan 2, 2024
Copy link
Contributor

mergify bot commented Jan 2, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 2, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 2, 2024

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 2, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 2, 2024
Signed-off-by: ricky <rickif@qq.com>
(cherry picked from commit d645805)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/KafkaRoutineLoadJob.java
mergify bot pushed a commit that referenced this pull request Jan 2, 2024
Signed-off-by: ricky <rickif@qq.com>
(cherry picked from commit d645805)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/KafkaRoutineLoadJob.java
mergify bot pushed a commit that referenced this pull request Jan 2, 2024
Signed-off-by: ricky <rickif@qq.com>
(cherry picked from commit d645805)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/KafkaRoutineLoadJob.java
mergify bot pushed a commit that referenced this pull request Jan 2, 2024
Signed-off-by: ricky <rickif@qq.com>
(cherry picked from commit d645805)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/routineload/KafkaRoutineLoadJob.java
@rickif rickif deleted the feat/routine-load-schedule branch January 3, 2024 01:54
rickif added a commit to rickif/starrocks that referenced this pull request Jan 3, 2024
rickif added a commit to rickif/starrocks that referenced this pull request Jan 3, 2024
wyb pushed a commit that referenced this pull request Jan 3, 2024
wyb pushed a commit that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants