Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support create or replace pipe #37658

Merged
merged 1 commit into from Dec 25, 2023

Conversation

mofeiatwork
Copy link
Contributor

@mofeiatwork mofeiatwork commented Dec 22, 2023

Why I'm doing:

What I'm doing:

  • Support syntax CREATE OR REPLACE PIPE

Fixes #37509

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Murphy <mofei@starrocks.com>
removePipe(pipe);
repo.deletePipe(pipe);
}

public void dropPipesOfDb(String dbName, long dbId) {
try {
lock.writeLock().lock();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky bug in this code is:
Attempting to replace a Pipe may fail if pipeMap.get(nameToId.get(dbIdAndName)) returns null, leading to a NullPointerException.

You can modify the code like this:

@@ -74,8 +74,13 @@
                 } else if (stmt.isReplace()) {
                     LOG.info("Pipe {} already exist, replace it with a new one", stmt.getPipeName());
                     Long pipeId = nameToId.get(dbIdAndName.getFirst());
-                    Pipe pipe = pipeMap.get(pipeId);
+                    Pipe pipe = pipeMap.get(dbIdAndName.getFirst());
+                    if (pipe == null) {
+                        throw new DdlException("Cannot replace non-existing pipe with name: " + dbIdAndName.getSecond());
+                    }
                     dropPipeImpl(pipe);
+                }
             }
 
             // Add pipe

In the modification above, I've added a null check for pipe before attempting to replace it. If pipe is null, an exception is thrown indicating that the pipe cannot be replaced because it doesn't exist. This avoids the potential NullPointerException. Additionally, make sure to use the correct key when obtaining pipe from pipeMap; the key should be derived from the resolved dbIdAndName, specifically the first element (dbId) in case dbIdAndName is a pair of database ID and name as the context suggests.

Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mofeiatwork mofeiatwork enabled auto-merge (squash) December 25, 2023 03:07
Copy link

[FE Incremental Coverage Report]

pass : 15 / 15 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/pipe/PipeManager.java 13 13 100.00% []
🔵 com/starrocks/sql/ast/pipe/CreatePipeStmt.java 2 2 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@mofeiatwork mofeiatwork merged commit 3db4497 into StarRocks:main Dec 25, 2023
58 checks passed
@mofeiatwork
Copy link
Contributor Author

@Mergifyio backport branch-3.2

Copy link
Contributor

mergify bot commented Dec 25, 2023

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 25, 2023
Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 3db4497)
wanpengfei-git pushed a commit that referenced this pull request Dec 25, 2023
Co-authored-by: Murphy <96611012+mofeiatwork@users.noreply.github.com>
Zhangg7723 pushed a commit to Zhangg7723/starrocks that referenced this pull request Dec 26, 2023
Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: 张敢 <zhanggan@deepexi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE OR REPLACE PIPE throws error
4 participants