New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix csv writer using incorrect number of columns #38045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
stephen-shelby
approved these changes
Dec 28, 2023
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 0 / 1 (00.00%) file detail
|
dirtysalt
approved these changes
Dec 29, 2023
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
Signed-off-by: Letian Jiang <letian.jiang@outlook.com> (cherry picked from commit 7276dab)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
Signed-off-by: Letian Jiang <letian.jiang@outlook.com> (cherry picked from commit 7276dab)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
Signed-off-by: Letian Jiang <letian.jiang@outlook.com> (cherry picked from commit 7276dab)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
Signed-off-by: Letian Jiang <letian.jiang@outlook.com> (cherry picked from commit 7276dab)
18 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
For cases like
The chunk has only one column. But two slots are required for output.
What I'm doing:
Use the size of
output_exprs
as the number of columns.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: