Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix csv writer using incorrect number of columns #38045

Merged
merged 1 commit into from Dec 29, 2023

Conversation

letian-jiang
Copy link
Contributor

@letian-jiang letian-jiang commented Dec 28, 2023

Why I'm doing:

For cases like

select 1 as a, 1 as b 
into outfile "file:///tmp/test3.csv" 
format as csv;

The chunk has only one column. But two slots are required for output.

What I'm doing:

Use the size of output_exprs as the number of columns.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/plain_text_builder.cpp 0 1 00.00% [49]

@dirtysalt dirtysalt merged commit 7276dab into StarRocks:main Dec 29, 2023
41 of 42 checks passed
Copy link

@Mergifyio backport branch-3.2

Copy link

@Mergifyio backport branch-3.1

Copy link

@Mergifyio backport branch-3.0

Copy link
Contributor

mergify bot commented Dec 29, 2023

backport branch-3.2

✅ Backports have been created

Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 3.0 label Dec 29, 2023
Copy link
Contributor

mergify bot commented Dec 29, 2023

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Dec 29, 2023
Copy link
Contributor

mergify bot commented Dec 29, 2023

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Dec 29, 2023

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 29, 2023
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
(cherry picked from commit 7276dab)
mergify bot pushed a commit that referenced this pull request Dec 29, 2023
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
(cherry picked from commit 7276dab)
mergify bot pushed a commit that referenced this pull request Dec 29, 2023
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
(cherry picked from commit 7276dab)
mergify bot pushed a commit that referenced this pull request Dec 29, 2023
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
(cherry picked from commit 7276dab)
wanpengfei-git pushed a commit that referenced this pull request Dec 29, 2023
…38045) (#38102)

Co-authored-by: Letian Jiang <letian.jiang@outlook.com>
wanpengfei-git pushed a commit that referenced this pull request Dec 29, 2023
…38045) (#38101)

Co-authored-by: Letian Jiang <letian.jiang@outlook.com>
wanpengfei-git pushed a commit that referenced this pull request Dec 29, 2023
…38045) (#38100)

Co-authored-by: Letian Jiang <letian.jiang@outlook.com>
wanpengfei-git pushed a commit that referenced this pull request Dec 29, 2023
…38045) (#38099)

Co-authored-by: Letian Jiang <letian.jiang@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants