Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Release pk state cache when txn is aborted #38499

Merged
merged 1 commit into from Jan 8, 2024

Conversation

TszKitLo40
Copy link
Contributor

@TszKitLo40 TszKitLo40 commented Jan 5, 2024

Why I'm doing:
if txn is aborted, pk state cache will not be released.
What I'm doing:

  1. Try to release state cache when txn is aborted.
  2. Clear compaction state cache when it is expired.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Zijie Lu <wslzj40@gmail.com>
Copy link

github-actions bot commented Jan 5, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 5, 2024

[BE Incremental Coverage Report]

pass : 10 / 10 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/update_manager.cpp 8 8 100.00% []
🔵 be/src/storage/lake/transactions.cpp 2 2 100.00% []

@sduzh sduzh merged commit c035777 into StarRocks:main Jan 8, 2024
51 checks passed
Copy link

github-actions bot commented Jan 8, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jan 8, 2024
Copy link
Contributor

mergify bot commented Jan 8, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 8, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 8, 2024
Signed-off-by: Zijie Lu <wslzj40@gmail.com>
(cherry picked from commit c035777)

# Conflicts:
#	be/src/storage/lake/transactions.cpp
#	be/test/storage/lake/primary_key_publish_test.cpp
mergify bot pushed a commit that referenced this pull request Jan 8, 2024
Signed-off-by: Zijie Lu <wslzj40@gmail.com>
(cherry picked from commit c035777)
wanpengfei-git pushed a commit that referenced this pull request Jan 8, 2024
TszKitLo40 added a commit to TszKitLo40/starrocks that referenced this pull request Jan 9, 2024
TszKitLo40 added a commit to TszKitLo40/starrocks that referenced this pull request Jan 9, 2024
wanpengfei-git pushed a commit that referenced this pull request Jan 9, 2024
…#38612)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Zijie Lu <wslzj40@gmail.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
luohaha added a commit to luohaha/starrocks that referenced this pull request Jan 12, 2024
…ks#38499) (StarRocks#38612)

Signed-off-by: Yixin Luo <18810541851@163.com>
Co-authored-by: Zijie Lu <wslzj40@gmail.com>
Co-authored-by: Yixin Luo <18810541851@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants