Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add datacache memory tracker to trace the datacache memory usage. (backport #38884) #39525

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 19, 2024

This is an automatic backport of pull request #38884 done by Mergify.
Cherry-pick of 729b4ed has failed:

On branch mergify/bp/branch-3.1/pr-38884
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 729b4edd95.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/block_cache/block_cache.cpp
	modified:   be/src/common/daemon.cpp
	modified:   be/src/http/default_path_handlers.cpp
	modified:   be/src/runtime/exec_env.h
	modified:   be/src/util/system_metrics.cpp
	modified:   be/src/util/system_metrics.h

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   be/src/block_cache/block_cache.h
	deleted by us:   be/src/http/action/memory_metrics_action.cpp
	both modified:   be/src/runtime/exec_env.cpp
	both modified:   be/src/script/script.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Why I'm doing: The datacache memory usage is unobservable, which brings difficulties to analyze process memory details.

What I'm doing:
Add datacache memory tracker to trace the datacache memory usage.
You can observe the datacache memory usage by follow urls:

http://${BE_HOST}:${BE_WEBSERVER_PORT}/mem_tracker
http://${BE_HOST}:${BE_WEBSERVER_PORT}/metrics
http://${BE_HOST}:${BE_WEBSERVER_PORT}/metrics/memory

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…ory usage. (#38884)

Signed-off-by: Gavin <yangguansuo@starrocks.com>
(cherry picked from commit 729b4ed)

# Conflicts:
#	be/src/block_cache/block_cache.h
#	be/src/http/action/memory_metrics_action.cpp
#	be/src/runtime/exec_env.cpp
#	be/src/script/script.cpp
@mergify mergify bot added the conflicts label Jan 19, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 19, 2024 02:53
@mergify mergify bot closed this Jan 19, 2024
auto-merge was automatically disabled January 19, 2024 02:53

Pull request was closed

Copy link
Contributor Author

mergify bot commented Jan 19, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-38884 branch January 19, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant