New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Optimize compaction resource usage for cloud native primary table #39611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luohaha
force-pushed
the
fix-lake-pk-compact-score
branch
2 times, most recently
from
January 20, 2024 00:09
f65e05d
to
9fd37dd
Compare
luohaha
changed the title
[Enhancement] Optimize compaction score calculation for lake pk table
[Enhancement] Optimize compaction score calculation and resource usage for lake pk table
Jan 20, 2024
luohaha
changed the title
[Enhancement] Optimize compaction score calculation and resource usage for lake pk table
[Enhancement] Optimize compaction resource usage for cloud native primary table
Jan 20, 2024
luohaha
force-pushed
the
fix-lake-pk-compact-score
branch
from
January 20, 2024 00:17
9fd37dd
to
7cc0039
Compare
sduzh
reviewed
Jan 20, 2024
tracymacding
approved these changes
Jan 20, 2024
Limit the number of rowsets per compaction merge but increase compaction times? |
kevincai
previously approved these changes
Jan 20, 2024
TszKitLo40
approved these changes
Jan 20, 2024
luohaha
force-pushed
the
fix-lake-pk-compact-score
branch
from
January 20, 2024 15:03
6b78489
to
fba34ca
Compare
kevincai
approved these changes
Jan 20, 2024
Signed-off-by: luohaha <18810541851@163.com>
luohaha
force-pushed
the
fix-lake-pk-compact-score
branch
from
January 20, 2024 23:37
fba34ca
to
eb2b74e
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 4 / 5 (80.00%) file detail
|
wyb
approved these changes
Jan 21, 2024
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
18 tasks
18 tasks
Seaven
pushed a commit
to Seaven/starrocks
that referenced
this pull request
Jan 30, 2024
…mary table (StarRocks#39611) Signed-off-by: luohaha <18810541851@163.com> Signed-off-by: Seaven <seaven_7@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
We need a way that it can:
What I'm doing:
lake_pk_compaction_merge_rowset_delta
, to limit the number of rowsets per compaction merge.Test result:
Continuously ingest 7GB of data into a tablet and observe the time consumed by compaction before and after optimization:
Before:
The longest compaction task cost
5min
.After:
The longest compaction task cost
1min
.This test result shows that new compaction policy can reduce 80% compaction resource usage.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: