[BugFix] Not ignore the leading space when parse delete predicate value #39797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1 is varchar key column, and delete from tbl where k1 = " a" success. the delete predicate will be parsed as k1 = "a" when quering, so the data is not really deleted. Signed-off-by: wyb <wybb86@gmail.com>
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kevincai
reviewed
Jan 24, 2024
| // group1: ([^\0=<>!\*]{1,64}) matches "c1" | ||
| // group2: ((?:=)|(?:!=)|(?:>>)|(?:<<)|(?:>=)|(?:<=)|(?:\*=)|(?:IS)) matches "=" | ||
| // group3: ((?:[\s\S]+)?) matches "1597751948193618247 and length(source)<1;\n;\n" | ||
| // group3: ((?:[\s\S]+)?) matches " 1597751948193618247 and length(source)<1;\n;\n" |
There was a problem hiding this comment.
out of curious, why use string to save sub conditions instead of a well defined structure, e.g. pb to save this.
There was a problem hiding this comment.
historical reason, and pb is used in cloud native table.
kevincai
approved these changes
Jan 25, 2024
sduzh
approved these changes
Jan 25, 2024
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
|
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
Merged
18 tasks
Merged
18 tasks
Merged
18 tasks
Merged
18 tasks
Seaven
pushed a commit
to Seaven/starrocks
that referenced
this pull request
Jan 30, 2024
…ue (StarRocks#39797) Signed-off-by: wyb <wybb86@gmail.com> Signed-off-by: Seaven <seaven_7@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
k1 is varchar key column, and delete from tbl where k1 = " a" success.
the delete predicate will be parsed as k1 = "a" when quering, so the data is not really deleted.
What I'm doing:
parse the predicate value correctly.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: