Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix bad case of pindex #39959

Merged
merged 1 commit into from Jan 26, 2024
Merged

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Jan 25, 2024

Why I'm doing:
The default max memory usage of one pindex is 100MB right now, so if the pindex memory usage is less than 100MB, it does not flush a l1 file to disk. To avoid keeping too many WAL logs in l0 file, we will compare the l0 file size and the memory usage. However, due to memory alignment, the size of L0 files is not always larger than the memory usage. This causes Pindex to dump a new snapshot each time, resulting in significant disk I/O when the snapshot file is large.

What I'm doing:
Dump a new snapshot only the L0 file size is too large.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: zhangqiang <qiangzh95@gmail.com>
@sevev sevev requested review from a team as code owners January 25, 2024 03:56
@mergify mergify bot assigned sevev Jan 25, 2024
@sevev sevev changed the title [BugFix] Fix bad case for pindex [BugFix] Fix bad case of pindex Jan 25, 2024
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/persistent_index.cpp 1 1 100.00% []

@wyb wyb enabled auto-merge (squash) January 25, 2024 11:22
@wyb wyb merged commit d9a6754 into StarRocks:main Jan 26, 2024
49 checks passed
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 26, 2024
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jan 26, 2024
Copy link

@Mergifyio backport branch-3.0

Copy link
Contributor

mergify bot commented Jan 26, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 26, 2024

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Jan 26, 2024
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Jan 26, 2024
Copy link
Contributor

mergify bot commented Jan 26, 2024

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 26, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 26, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit d9a6754)
mergify bot pushed a commit that referenced this pull request Jan 26, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit d9a6754)
mergify bot pushed a commit that referenced this pull request Jan 26, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit d9a6754)
mergify bot pushed a commit that referenced this pull request Jan 26, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
(cherry picked from commit d9a6754)
wanpengfei-git pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: zhangqiang <qiangzh95@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: zhangqiang <qiangzh95@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: zhangqiang <qiangzh95@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: zhangqiang <qiangzh95@gmail.com>
motto1314 pushed a commit to motto1314/starrocks that referenced this pull request Jan 30, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Seaven pushed a commit to Seaven/starrocks that referenced this pull request Jan 30, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Signed-off-by: Seaven <seaven_7@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants