New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix bad case of pindex #39959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
sevev
changed the title
[BugFix] Fix bad case for pindex
[BugFix] Fix bad case of pindex
Jan 25, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
decster
approved these changes
Jan 25, 2024
wyb
approved these changes
Jan 25, 2024
kevincai
approved these changes
Jan 26, 2024
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
✅ Backports have been created
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com> (cherry picked from commit d9a6754)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com> (cherry picked from commit d9a6754)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com> (cherry picked from commit d9a6754)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com> (cherry picked from commit d9a6754)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jan 26, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Jan 26, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Jan 26, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Jan 26, 2024
motto1314
pushed a commit
to motto1314/starrocks
that referenced
this pull request
Jan 30, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com>
Seaven
pushed a commit
to Seaven/starrocks
that referenced
this pull request
Jan 30, 2024
Signed-off-by: zhangqiang <qiangzh95@gmail.com> Signed-off-by: Seaven <seaven_7@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
The default max memory usage of one pindex is 100MB right now, so if the pindex memory usage is less than 100MB, it does not flush a l1 file to disk. To avoid keeping too many WAL logs in l0 file, we will compare the l0 file size and the memory usage. However, due to memory alignment, the size of L0 files is not always larger than the memory usage. This causes Pindex to dump a new snapshot each time, resulting in significant disk I/O when the snapshot file is large.
What I'm doing:
Dump a new snapshot only the L0 file size is too large.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: