Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix bug dynamic partition date type does not support hour #40256

Merged
merged 3 commits into from Jan 30, 2024
Merged

[BugFix] Fix bug dynamic partition date type does not support hour #40256

merged 3 commits into from Jan 30, 2024

Conversation

Astralidea
Copy link
Contributor

Why I'm doing:
Dynamic partitioning supports hour, but it does not consider that date type partitioning cannot be supported.

What I'm doing:

  1. When creating a table, directly prevent such prompts from being created.
  2. Provide friendly error prompts for stock creation.
  3. Add a little more coverage for other issues that may go wrong.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Astralidea
Fix bug dynamic partition date type does not support hour
39edad5 
Signed-off-by: Astralidea <astralidea@163.com>
@Astralidea Astralidea requested a review from a team as a code owner January 29, 2024 09:12
@Astralidea
Fix.
61da6d3 
Signed-off-by: Astralidea <astralidea@163.com>
@Astralidea Astralidea enabled auto-merge (squash) January 29, 2024 12:26
@HangyuanLiu HangyuanLiu self-assigned this Jan 29, 2024
@nshangyiming nshangyiming self-assigned this Jan 30, 2024
@Astralidea
Fix.
2590e06 
Signed-off-by: Astralidea <astralidea@163.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 20 / 20 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/DynamicPartitionProperty.java 2 2 100.00% []
🔵 com/starrocks/common/util/DynamicPartitionUtil.java 6 6 100.00% []
🔵 com/starrocks/clone/DynamicPartitionScheduler.java 12 12 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@Astralidea Astralidea merged commit 7c55d6f into StarRocks:main Jan 30, 2024
43 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 30, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jan 30, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Jan 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024 •
edited

backport branch-3.2

✅ Backports have been created

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Jan 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024 •
edited

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024 •
edited

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 30, 2024 •
edited

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 30, 2024
@Astralidea @mergify
[BugFix] Fix bug dynamic partition date type does not support hour (#…
2b91a5b 
…40256)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 7c55d6f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/util/DynamicPartitionUtil.java
@mergify mergify bot mentioned this pull request Jan 30, 2024
Closed
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
@Astralidea @mergify
[BugFix] Fix bug dynamic partition date type does not support hour (#…
86f26c6 
…40256)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 7c55d6f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/util/DynamicPartitionUtil.java
#	fe/fe-core/src/test/java/com/starrocks/clone/DynamicPartitionSchedulerTest.java
@mergify mergify bot mentioned this pull request Jan 30, 2024
Closed
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
@Astralidea @mergify
[BugFix] Fix bug dynamic partition date type does not support hour (#…
af9328a 
…40256)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 7c55d6f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/clone/DynamicPartitionScheduler.java
#	fe/fe-core/src/main/java/com/starrocks/common/util/DynamicPartitionUtil.java
#	fe/fe-core/src/test/java/com/starrocks/clone/DynamicPartitionSchedulerTest.java
@mergify mergify bot mentioned this pull request Jan 30, 2024
Closed
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
@Astralidea @mergify
[BugFix] Fix bug dynamic partition date type does not support hour (#…
42b4196 
…40256)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit 7c55d6f)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/clone/DynamicPartitionScheduler.java
#	fe/fe-core/src/main/java/com/starrocks/common/util/DynamicPartitionUtil.java
#	fe/fe-core/src/test/java/com/starrocks/clone/DynamicPartitionSchedulerTest.java
@mergify mergify bot mentioned this pull request Jan 30, 2024
Closed
18 tasks
motto1314 pushed a commit to motto1314/starrocks that referenced this pull request Jan 30, 2024
@Astralidea @motto1314
[BugFix] Fix bug dynamic partition date type does not support hour (S…
befb697 
…tarRocks#40256)

Signed-off-by: Astralidea <astralidea@163.com>
Astralidea added a commit that referenced this pull request Jan 30, 2024
@Astralidea
[BugFix] Fix bug dynamic partition date type does not support hour (b…
cd791ca 
…ackport #40256) (#40325)

Signed-off-by: Astralidea <astralidea@163.com>
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
@Astralidea @mergify
[BugFix] Fix bug dynamic partition date type does not support hour (b…
ceb8006 
…ackport #40256) (#40325)

Signed-off-by: Astralidea <astralidea@163.com>
(cherry picked from commit cd791ca)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/clone/DynamicPartitionSchedulerTest.java
Astralidea added a commit that referenced this pull request Jan 30, 2024
@Astralidea
[BugFix] Fix bug dynamic partition date type does not support hour (b…
41a133a 
…ackport #40256) (#40338)

Signed-off-by: Astralidea <astralidea@163.com>
Astralidea added a commit that referenced this pull request Jan 30, 2024
@Astralidea
[BugFix] Fix bug dynamic partition date type does not support hour (b…
67151f0 
…ackport #40256) (#40362)

Signed-off-by: Astralidea <astralidea@163.com>
Astralidea added a commit that referenced this pull request Feb 5, 2024
@Astralidea
[BugFix] Fix bug dynamic partition date type does not support hour (b…
4981772 
…ackport #40256) (#40328)

Signed-off-by: Astralidea <astralidea@163.com>
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HangyuanLiu HangyuanLiu HangyuanLiu left review comments

@starrocks-cr starrocks-cr[bot] starrocks-cr left review comments

@gengjun-git gengjun-git gengjun-git approved these changes

@nshangyiming nshangyiming nshangyiming approved these changes

Assignees

@Astralidea Astralidea

@HangyuanLiu HangyuanLiu

@nshangyiming nshangyiming

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Astralidea @HangyuanLiu @gengjun-git @nshangyiming