Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix TabletSchemaMap dead lock #40406

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[BugFix] fix TabletSchemaMap dead lock #40406

merged 1 commit into from
Jan 31, 2024

Conversation

kevincai
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai
[BugFix] fix TabletSchemaMap dead lock
0e6585b 
* fixes StarRocks#40395

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai kevincai requested a review from a team as a code owner January 31, 2024 03:01
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 12 / 12 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/tablet_schema_map.cpp 12 12 100.00% []

@sduzh sduzh enabled auto-merge (squash) January 31, 2024 04:51
@sduzh sduzh merged commit caa5fb0 into StarRocks:main Jan 31, 2024
46 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 31, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jan 31, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024 •
edited

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024 •
edited

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024 •
edited

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2024 •
edited

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@kevincai @mergify
[BugFix] fix TabletSchemaMap dead lock (#40406)
7eeeea0 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit caa5fb0)
@mergify mergify bot mentioned this pull request Jan 31, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@kevincai @mergify
[BugFix] fix TabletSchemaMap dead lock (#40406)
48cfe0e 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit caa5fb0)
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@kevincai @mergify
[BugFix] fix TabletSchemaMap dead lock (#40406)
2dd0bf0 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit caa5fb0)
This was referenced Jan 31, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2024
@kevincai @mergify
[BugFix] fix TabletSchemaMap dead lock (#40406)
ca1db94 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit caa5fb0)
@mergify mergify bot mentioned this pull request Jan 31, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 31, 2024
@mergify @kevincai
[BugFix] fix TabletSchemaMap dead lock (backport #40406) (#40419)
50ace91 
Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 31, 2024
@mergify @kevincai
[BugFix] fix TabletSchemaMap dead lock (backport #40406) (#40421)
7659c59 
Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jan 31, 2024
@mergify @kevincai
[BugFix] fix TabletSchemaMap dead lock (backport #40406) (#40422)
cfbaef9 
Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 5, 2024
@mergify @kevincai
[BugFix] fix TabletSchemaMap dead lock (backport #40406) (#40420)
17fd9ec 
Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
@kevincai kevincai deleted the fix-tabletmetamap-deadlock branch March 5, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr left review comments

@imay imay imay approved these changes

@sduzh sduzh sduzh approved these changes

Assignees

@kevincai kevincai

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] Deadlock in starrocks::TabletSchemaMap
3 participants
@kevincai @imay @sduzh