Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] change the task execution user to current_user when creating #40670

Merged

Conversation

mofeiatwork
Copy link
Contributor

@mofeiatwork mofeiatwork commented Feb 4, 2024

Why I'm doing:

  • Current we use the root to execute all tasks, but it's not reasonable in some cases
  • For example, submit a task with user1 but finally execute as root will muddle the privilege and resource management

What I'm doing:

  • Change the task execution user to creator

Behavior change:

  • Previous use the ROOT to execute all tasks
  • Current use the creator to executor all tasks

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Signed-off-by: Murphy <mofei@starrocks.com>
Signed-off-by: Murphy <mofei@starrocks.com>
Copy link

sonarcloud bot commented Feb 4, 2024

Copy link

github-actions bot commented Feb 4, 2024

[FE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/TaskBuilder.java 4 4 100.00% []

Copy link

github-actions bot commented Feb 4, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@mofeiatwork mofeiatwork merged commit 83f5a38 into StarRocks:main Feb 4, 2024
51 of 52 checks passed
Copy link

github-actions bot commented Feb 4, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Feb 4, 2024
Copy link

github-actions bot commented Feb 4, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Feb 4, 2024
Copy link
Contributor

mergify bot commented Feb 4, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Feb 4, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 4, 2024
…ating (#40670)

Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 83f5a38)
mergify bot pushed a commit that referenced this pull request Feb 4, 2024
…ating (#40670)

Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 83f5a38)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/scheduler/TaskBuilder.java
mofeiatwork added a commit that referenced this pull request Feb 6, 2024
…ating (#40670)

Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 83f5a38)
Signed-off-by: Murphy <mofei@starrocks.com>
mofeiatwork added a commit that referenced this pull request Feb 6, 2024
…ating (#40670)

Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 83f5a38)
Signed-off-by: Murphy <mofei@starrocks.com>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/scheduler/TaskBuilder.java
wanpengfei-git pushed a commit that referenced this pull request Feb 6, 2024
…ating (backport #40670) (#40698)

Co-authored-by: Murphy <96611012+mofeiatwork@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 10, 2024
…ating (backport #40670) (#40697)

Signed-off-by: Murphy <mofei@starrocks.com>
Co-authored-by: Murphy <96611012+mofeiatwork@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants