Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support trino to_char function #41217

Merged
merged 1 commit into from Feb 20, 2024
Merged

Conversation

kangkaisen
Copy link
Collaborator

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

liuyehcf
liuyehcf previously approved these changes Feb 20, 2024
@kangkaisen kangkaisen changed the title Support trino to_char function [Feature] Support trino to_char function Feb 20, 2024
Signed-off-by: kangkaisen <kangkaisen@apache.org>
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@kangkaisen kangkaisen enabled auto-merge (squash) February 20, 2024 07:46
Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/parser/trino/Trino2SRFunctionCallTransformer.java 2 2 100.00% []

@kangkaisen kangkaisen merged commit f308f46 into StarRocks:main Feb 20, 2024
44 of 45 checks passed
@kangkaisen kangkaisen deleted the to_char branch February 20, 2024 09:31
@kangkaisen
Copy link
Collaborator Author

https://github.com/Mergifyio backport branch-3.2

@kangkaisen
Copy link
Collaborator Author

https://github.com/Mergifyio backport branch-3.1

Copy link
Contributor

mergify bot commented Feb 20, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Feb 20, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: kangkaisen <kangkaisen@apache.org>
(cherry picked from commit f308f46)
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: kangkaisen <kangkaisen@apache.org>
(cherry picked from commit f308f46)
wanpengfei-git pushed a commit that referenced this pull request Feb 20, 2024
Co-authored-by: kangkaisen <kangkaisen@apache.org>
wanpengfei-git pushed a commit that referenced this pull request Feb 20, 2024
Co-authored-by: kangkaisen <kangkaisen@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants