Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix convert left outer join to inner join bug #41428

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[BugFix] fix convert left outer join to inner join bug #41428

merged 1 commit into from
Feb 22, 2024

Conversation

ABingHuang
Copy link
Contributor

Why I'm doing:

left outer join is incorrecly converted into inner join, The reason is that pushdownNotNullPredicates of OptimizerContext is not clear after RewriteTreeTask rewrite retry.

What I'm doing:

reset OptimizerContext after every RewriteTreeTask run.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ABingHuang ABingHuang requested a review from a team as a code owner February 22, 2024 08:22
@github-actions github-actions bot added the 3.2 label Feb 22, 2024
Seaven
Seaven previously approved these changes Feb 22, 2024
View reviewed changes
@ABingHuang
fix convert left outer join to inner join bug
5b87d42 
Signed-off-by: ABingHuang <codekhuang@163.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ABingHuang ABingHuang enabled auto-merge (squash) February 22, 2024 13:07
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/task/RewriteTreeTask.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@ABingHuang ABingHuang merged commit 9eb8155 into StarRocks:main Feb 22, 2024
49 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Feb 22, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Feb 22, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Feb 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 22, 2024 •
edited

backport branch-3.2

✅ Backports have been created

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 22, 2024 •
edited

backport branch-3.1

✅ Backports have been created

@github-actions github-actions bot removed the 2.5 label Feb 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 22, 2024 •
edited

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 22, 2024 •
edited

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 22, 2024
@ABingHuang @mergify
[BugFix] fix convert left outer join to inner join bug (#41428)
35cfc14 
Signed-off-by: ABingHuang <codekhuang@163.com>
(cherry picked from commit 9eb8155)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
@mergify mergify bot mentioned this pull request Feb 22, 2024
Closed
18 tasks
mergify bot pushed a commit that referenced this pull request Feb 22, 2024
@ABingHuang @mergify
[BugFix] fix convert left outer join to inner join bug (#41428)
578cbb1 
Signed-off-by: ABingHuang <codekhuang@163.com>
(cherry picked from commit 9eb8155)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
mergify bot pushed a commit that referenced this pull request Feb 22, 2024
@ABingHuang @mergify
[BugFix] fix convert left outer join to inner join bug (#41428)
3aebfbb 
Signed-off-by: ABingHuang <codekhuang@163.com>
(cherry picked from commit 9eb8155)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/OptimizerContext.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
This was referenced Feb 22, 2024
Closed
Closed
mergify bot pushed a commit that referenced this pull request Feb 22, 2024
@ABingHuang @mergify
[BugFix] fix convert left outer join to inner join bug (#41428)
ca93053 
Signed-off-by: ABingHuang <codekhuang@163.com>
(cherry picked from commit 9eb8155)
@mergify mergify bot mentioned this pull request Feb 22, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Feb 23, 2024
@mergify @ABingHuang
[BugFix] fix convert left outer join to inner join bug (backport #41428…
38c6646 
…) (#41469)

Co-authored-by: ABing <101158374+ABingHuang@users.noreply.github.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Feb 23, 2024
@ABingHuang
[BugFix] fix convert left outer join to inner join bug (StarRocks#41428)
e983537 
Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Feb 23, 2024
@ABingHuang
[BugFix] fix convert left outer join to inner join bug (StarRocks#41428)
57f80c5 
Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit that referenced this pull request Feb 23, 2024
@ABingHuang
[BugFix] Fix left outer join plan bug for 3.1 (backport #39331 #41428) (
01a4a9d 
#41549)

Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit to ABingHuang/starrocks that referenced this pull request Feb 27, 2024
@ABingHuang
[BugFix] fix convert left outer join to inner join bug (StarRocks#41428)
8ff93c7 
Signed-off-by: ABingHuang <codekhuang@163.com>
ABingHuang added a commit that referenced this pull request Feb 27, 2024
@ABingHuang
[BugFix] Fix left outer join plan bug for 3.2 (backport #39331)(backp…
78e52f2 
…ort #41428) (#41703)

Signed-off-by: ABingHuang <codekhuang@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@packy92 packy92 packy92 approved these changes

Assignees

@ABingHuang ABingHuang

Labels
2.5-merged 3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ABingHuang @Seaven @packy92