Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] window lose tuple.computeMemory #41442

Merged
merged 2 commits into from
Feb 26, 2024
Merged

[BugFix] window lose tuple.computeMemory #41442

merged 2 commits into from
Feb 26, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Feb 22, 2024 •
edited
Loading

Why I'm doing:

window operator doesn't called outputTupleDesc.computeMemLayout();

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Seaven Seaven requested review from a team as code owners February 22, 2024 11:47
@mergify mergify bot assigned Seaven Feb 22, 2024
@Seaven
[BugFix] window lose tuple.computeMemory
0bdaef5 
Signed-off-by: Seaven <seaven_7@qq.com>
@Seaven
up
d4a777e 
Signed-off-by: Seaven <seaven_7@qq.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/plan/PlanFragmentBuilder.java 1 1 100.00% []
🔵 com/starrocks/analysis/SlotDescriptor.java 3 3 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 1 / 3 (33.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/aggregator.cpp 1 3 33.33% [1140, 1141]

@kangkaisen kangkaisen merged commit 01ef74d into StarRocks:main Feb 26, 2024
58 of 60 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Feb 26, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Feb 26, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Feb 26, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Feb 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 26, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 26, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 26, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 26, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 26, 2024
@Seaven @mergify
[BugFix] window lose tuple.computeMemory (#41442)
774b791 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 01ef74d)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/WindowTest.java
mergify bot pushed a commit that referenced this pull request Feb 26, 2024
@Seaven @mergify
[BugFix] window lose tuple.computeMemory (#41442)
89b5b37 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 01ef74d)
mergify bot pushed a commit that referenced this pull request Feb 26, 2024
@Seaven @mergify
[BugFix] window lose tuple.computeMemory (#41442)
d2d5aad 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 01ef74d)
This was referenced Feb 26, 2024
Merged
Merged
Closed
mergify bot pushed a commit that referenced this pull request Feb 26, 2024
@Seaven @mergify
[BugFix] window lose tuple.computeMemory (#41442)
00e2b1f 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 01ef74d)

# Conflicts:
#	be/src/exec/vectorized/aggregator.cpp
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/WindowTest.java
@mergify mergify bot mentioned this pull request Feb 26, 2024
Closed
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Feb 26, 2024
@mergify @Seaven
[BugFix] window lose tuple.computeMemory (backport #41442) (#41648)
1787e06 
Co-authored-by: Seaven <seaven_7@qq.com>
Seaven added a commit that referenced this pull request Feb 26, 2024
@Seaven
[BugFix] window lose tuple.computeMemory (#41442)
2dede35 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 01ef74d)
Seaven added a commit to Seaven/starrocks that referenced this pull request Feb 26, 2024
@Seaven
[BugFix] window lose tuple.computeMemory (backport StarRocks#41442)
24459cb 
Signed-off-by: Seaven <seaven_7@qq.com>
Seaven added a commit that referenced this pull request Feb 27, 2024
@Seaven
[BugFix] window lose tuple.computeMemory (#41442)
75342f3 
Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 01ef74d)
kangkaisen pushed a commit that referenced this pull request Feb 27, 2024
@Seaven
[BugFix] window lose tuple.computeMemory (backport #41442) (#41674)
37607d1 
Signed-off-by: Seaven <seaven_7@qq.com>
kangkaisen pushed a commit that referenced this pull request Feb 27, 2024
@Seaven
[BugFix] window lose tuple.computeMemory (backport #41442) (#41673)
4d1289c 
Signed-off-by: Seaven <seaven_7@qq.com>
wanpengfei-git pushed a commit that referenced this pull request Feb 27, 2024
@mergify @Seaven
[BugFix] window lose tuple.computeMemory (backport #41442) (#41649)
d9c50c2 
Co-authored-by: Seaven <seaven_7@qq.com>
@Seaven Seaven deleted the window branch March 4, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@stdpain stdpain stdpain approved these changes

Assignees

@Seaven Seaven

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Seaven @kangkaisen @stdpain