Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Control implicit cast optimization by cbo_eq_base_type (backport #40619) #41712

Merged
merged 1 commit into from Feb 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2024

This is an automatic backport of pull request #40619 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Why I'm doing:

What I'm doing:

ImplicitCastRule will optimize operator: str = 1/st > 1, variable operator = constant operator, will cast constant opterator to variable operator type at first

Follow: #34208

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 9536578)
@Seaven Seaven force-pushed the mergify/bp/branch-3.1/pr-40619 branch from 3735115 to 5a7e4f0 Compare February 27, 2024 06:40
Copy link

sonarcloud bot commented Feb 27, 2024

@wanpengfei-git wanpengfei-git merged commit 32e81cb into branch-3.1 Feb 28, 2024
27 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-40619 branch February 28, 2024 02:08
@Seaven Seaven changed the title [Enhancement] Control implicit cast optimization by cbo_eq_type (backport #40619) [Enhancement] Control implicit cast optimization by cbo_eq_base_type (backport #40619) Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants