[Enhancement] Control implicit cast optimization by cbo_eq_base_type #40619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seaven <seaven_7@qq.com>
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/scalar/ImplicitCastRule.java
Show resolved
Hide resolved
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 23 / 23 (100.00%) file detail
|
Seaven
changed the title
kangkaisen
approved these changes
Feb 23, 2024
packy92
approved these changes
Feb 27, 2024
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
|
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
|
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
Merged
23 tasks
Seaven
added a commit
to Seaven/starrocks
that referenced
this pull request
Feb 27, 2024
…port StarRocks#40619) Signed-off-by: Seaven <seaven_7@qq.com>
Seaven
added a commit
to Seaven/starrocks
that referenced
this pull request
Feb 27, 2024
…Rocks#40619) Signed-off-by: Seaven <seaven_7@qq.com>
Seaven
added a commit
to Seaven/starrocks
that referenced
this pull request
Feb 27, 2024
…Rocks#40619) Signed-off-by: Seaven <seaven_7@qq.com>
Seaven
changed the title
23 tasks
This was referenced Mar 18, 2024
23 tasks
This was referenced Mar 28, 2024
24 tasks
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
ImplicitCastRule will optimize operator:
str = 1/st > 1, variable operator = constant operator, will cast constant opterator to variable operator type at firstFollow: #34208
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: