Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Replace_if_not_null support bitmap type #42034

Merged
merged 1 commit into from Mar 5, 2024

Conversation

trueeyu
Copy link
Contributor

@trueeyu trueeyu commented Mar 4, 2024

Why I'm doing:

We often use replace_if_not_null to implement partial column updates on aggregate tables, but the current bitmap type does not support replace_if_not_null.

What I'm doing:

Aggregate table support replace_if_not_null for bitmap type.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@trueeyu
Copy link
Contributor Author

trueeyu commented Mar 4, 2024

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Mar 4, 2024

rebase

✅ Branch has been successfully rebased

@trueeyu
Copy link
Contributor Author

trueeyu commented Mar 5, 2024

https://github.com/Mergifyio rebase

Signed-off-by: trueeyu <lxhhust350@qq.com>
Copy link
Contributor

mergify bot commented Mar 5, 2024

rebase

✅ Branch has been successfully rebased

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

github-actions bot commented Mar 5, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Mar 5, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@imay imay merged commit 4c00832 into StarRocks:main Mar 5, 2024
48 checks passed
Copy link

github-actions bot commented Mar 5, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

@Mergifyio backport branch-3.0

Copy link

github-actions bot commented Mar 5, 2024

@Mergifyio backport branch-2.5

Copy link
Contributor

mergify bot commented Mar 5, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Mar 5, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Mar 5, 2024

backport branch-3.0

✅ Backports have been created

Copy link
Contributor

mergify bot commented Mar 5, 2024

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 5, 2024
Why I'm doing:
We often use replace_if_not_null to implement partial column updates on aggregate tables, but the current bitmap type does not support replace_if_not_null.

What I'm doing:
Aggregate table support replace_if_not_null for bitmap type.

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 4c00832)
mergify bot pushed a commit that referenced this pull request Mar 5, 2024
Why I'm doing:
We often use replace_if_not_null to implement partial column updates on aggregate tables, but the current bitmap type does not support replace_if_not_null.

What I'm doing:
Aggregate table support replace_if_not_null for bitmap type.

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 4c00832)
mergify bot pushed a commit that referenced this pull request Mar 5, 2024
Why I'm doing:
We often use replace_if_not_null to implement partial column updates on aggregate tables, but the current bitmap type does not support replace_if_not_null.

What I'm doing:
Aggregate table support replace_if_not_null for bitmap type.

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 4c00832)
mergify bot pushed a commit that referenced this pull request Mar 5, 2024
Why I'm doing:
We often use replace_if_not_null to implement partial column updates on aggregate tables, but the current bitmap type does not support replace_if_not_null.

What I'm doing:
Aggregate table support replace_if_not_null for bitmap type.

Signed-off-by: trueeyu <lxhhust350@qq.com>
(cherry picked from commit 4c00832)
wanpengfei-git pushed a commit that referenced this pull request Mar 5, 2024
wanpengfei-git pushed a commit that referenced this pull request Mar 5, 2024
wanpengfei-git pushed a commit that referenced this pull request Mar 5, 2024
wanpengfei-git pushed a commit that referenced this pull request Mar 5, 2024
@@ -112,7 +112,6 @@ public enum AggregateType {

// all types except bitmap, hll, percentile and complex types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the comment

Copy link
Contributor

mergify bot commented Mar 7, 2024

rebase

☑️ Nothing to do

  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position=-1 [📌 rebase requirement]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants