-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] remain unsupported operator when dict mapping rewrite #42230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packy92
force-pushed
the
main_fix_low_card
branch
from
March 6, 2024 12:38
3b0aa8e
to
421dd8d
Compare
Quality Gate passedIssues Measures |
[FE Incremental Coverage Report]❌ fail : 3 / 4 (75.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Mar 7, 2024
stdpain
approved these changes
Mar 7, 2024
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
(cherry picked from commit b36f084) # Conflicts: # test/sql/test_low_cardinality/R/test_low_cardinality # test/sql/test_low_cardinality/T/test_low_cardinality
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
(cherry picked from commit b36f084)
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
(cherry picked from commit b36f084) # Conflicts: # test/sql/test_low_cardinality/R/test_low_cardinality # test/sql/test_low_cardinality/T/test_low_cardinality
This was referenced Mar 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
(cherry picked from commit b36f084) # Conflicts: # test/sql/test_low_cardinality/R/test_low_cardinality # test/sql/test_low_cardinality/T/test_low_cardinality
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
fails in
Preconditions.checkState(usedColumns.cardinality() == 1);
What I'm doing:
For sql:
When rewriting the nested function,
S_ADDRESS = 'a'
can apply dict withhasApplied = true
,SUBSTR(MD5(S_ADDRESS), 1, 8)
has unsupported func and its rewrite result isSUBSTR(MD5(dict_mapping(S_ADDRESS)), 1, 8)
withhasApplied = false
anddisableApplied = false
.For the if function, the rewrite context is
hasApplied = true
anddisableApplied = false
, it choose the wrong rewrite branch.We need to propagate the
hasUnsupportedOperator
to the outer to ensure the scalarOperator with hasApplied child and has unsuppored child to do dict mapping process again.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: