Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix pk table replication in cross cluster replication for shared-nothing mode #42260

Merged
merged 1 commit into from Mar 7, 2024
Merged

[BugFix] Fix pk table replication in cross cluster replication for shared-nothing mode #42260

merged 1 commit into from Mar 7, 2024

Conversation

xiangguangyxg
Copy link
Contributor

@xiangguangyxg xiangguangyxg commented Mar 7, 2024 •
edited

Why I'm doing:

Pk table replication may crash due to rowset id convertion

What I'm doing:

Fix pk table replication in cross cluster replication

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@xiangguangyxg
[BugFix] Fix pk table replication in cross cluster replication for sh…
06814ea 
…ared-nothing mode

Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>
@xiangguangyxg xiangguangyxg requested a review from a team as a code owner March 7, 2024 08:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

[BE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/replication_txn_manager.cpp 1 1 100.00% []

@wyb wyb enabled auto-merge (squash) March 7, 2024 10:04
@wyb wyb merged commit 9ad8786 into StarRocks:main Mar 7, 2024
48 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Mar 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2024 •
edited

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 7, 2024 •
edited

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 7, 2024
@xiangguangyxg @mergify
[BugFix] Fix pk table replication in cross cluster replication for sh…
6e51049 
…ared-nothing mode (#42260)

Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>
(cherry picked from commit 9ad8786)
@mergify mergify bot mentioned this pull request Mar 7, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Mar 7, 2024
@xiangguangyxg @mergify
[BugFix] Fix pk table replication in cross cluster replication for sh…
ea623eb 
…ared-nothing mode (#42260)

Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>
(cherry picked from commit 9ad8786)
@mergify mergify bot mentioned this pull request Mar 7, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Mar 7, 2024
@mergify @xiangguangyxg
[BugFix] Fix pk table replication in cross cluster replication for sh…
6c1bb6b 
…ared-nothing mode (backport #42260) (#42274)

Co-authored-by: xiangguangyxg <110401425+xiangguangyxg@users.noreply.github.com>
wanpengfei-git pushed a commit that referenced this pull request Mar 7, 2024
@mergify @xiangguangyxg
[BugFix] Fix pk table replication in cross cluster replication for sh…
7de8553 
…ared-nothing mode (backport #42260) (#42275)

Co-authored-by: xiangguangyxg <110401425+xiangguangyxg@users.noreply.github.com>
wxl24life pushed a commit to wxl24life/starrocks that referenced this pull request Mar 28, 2024
@xiangguangyxg @miomiocat
[Backport][BugFix] Fix pk table replication in cross cluster replicat…
4b15dec 
…ion for shared-nothing mode (backport StarRocks#42260) (StarRocks#42275)

Co-authored-by: xiangguangyxg <110401425+xiangguangyxg@users.noreply.github.com>
wxl24life pushed a commit to wxl24life/starrocks that referenced this pull request Apr 22, 2024
@xiangguangyxg @miomiocat
[Backport][BugFix] Fix pk table replication in cross cluster replicat…
90c21f7 
…ion for shared-nothing mode (backport StarRocks#42260) (StarRocks#42275)

Co-authored-by: xiangguangyxg <110401425+xiangguangyxg@users.noreply.github.com>
wxl24life pushed a commit to wxl24life/starrocks that referenced this pull request Apr 22, 2024
@xiangguangyxg @miomiocat
[Backport][BugFix] Fix pk table replication in cross cluster replicat…
ad9ea91 
…ion for shared-nothing mode (backport StarRocks#42260) (StarRocks#42275)

Co-authored-by: xiangguangyxg <110401425+xiangguangyxg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@sduzh sduzh sduzh approved these changes

Assignees

@xiangguangyxg xiangguangyxg

Labels
3.1-merged 3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiangguangyxg @wyb @sduzh