Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] to avoid s3:// not supported case (backport #42369) #42460

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 12, 2024

This is an automatic backport of pull request #42369 done by Mergify.
Cherry-pick of 8956689 has failed:

On branch mergify/bp/branch-2.5/pr-42369
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 8956689a67.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   conf/core-site.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/CMakeLists.txt
	both modified:   build.sh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

## Why I'm doing:

Some user create database s3 glue catalog reports

Unexpected exception: Got exception: org.apache.hadoop.fs.UnsupportedFileSystemException No FileSystem for scheme "s3"

Some user hit same problem when access HURI MOR table

Failed to open the off-heap table scanner. java exception details: java.io.IOException: Failed to open the hudi MOR slice reader.
	at com.starrocks.hudi.reader.HudiSliceScanner.open(HudiSliceScanner.java:219)
Caused by: org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme "s3"

What I'm doing:

I think we can make s3 scheme maps to org.apache.hadoop.fs.s3a.S3AFileSystem by default.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: yanz <dirtysalt1987@gmail.com>
(cherry picked from commit 8956689)

# Conflicts:
#	be/CMakeLists.txt
#	build.sh
@mergify mergify bot added the conflicts label Mar 12, 2024
Copy link
Contributor Author

mergify bot commented Mar 12, 2024

Cherry-pick of 8956689 has failed:

On branch mergify/bp/branch-2.5/pr-42369
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 8956689a67.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   conf/core-site.xml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/CMakeLists.txt
	both modified:   build.sh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 12, 2024 01:14
@mergify mergify bot closed this Mar 12, 2024
auto-merge was automatically disabled March 12, 2024 01:14

Pull request was closed

Copy link
Contributor Author

mergify bot commented Mar 12, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-42369 branch March 12, 2024 01:14
@dirtysalt dirtysalt restored the mergify/bp/branch-2.5/pr-42369 branch March 12, 2024 01:37
@dirtysalt dirtysalt reopened this Mar 12, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 12, 2024 01:37
Signed-off-by: yanz <dirtysalt1987@gmail.com>
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wanpengfei-git wanpengfei-git merged commit b36fe6a into branch-2.5 Mar 12, 2024
24 of 25 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-42369 branch March 12, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants